Declaration Generator/LG: Shift line down to closing paragraph

hackforla / expunge-assist

Expunge Assist is a free digital tool specifically designed to aid Californians with arrest and conviction histories in clearing their criminal records.

https://expungeassist.org

40 stars 17 forks source link

Declaration Generator/LG: Shift line down to closing paragraph #1503

Open SamHyler opened 2 months ago

SamHyler commented 2 months ago

Title

Shift the final line down to the closing paragraph

Overview

High priority quick fix issue from Bonnie's feedback (https://github.com/hackforla/expunge-assist/issues/1461). The final line in the final paragraph ("Why") before the closing in the LG/Declaration generator needs to be moved to the closing paragraph.

Action Items

[x] Check off these boxes as they are done and document progress and updates in the comments below
[x] Find the final two paragraphs ("why" and the closing paragraph) in Figma
[x] Move the final line that is pre-written by EA/the generator in the "Why" paragraph to the closing paragraph. The line says "Thank you for considering my case."
[x] Update final copy in all 3 spaces: Mobile, Desktop, and the Content SOT on Google Docs
[ ] Tag the Content leads on this issue by adding the label ready for content lead and pinging on slack

Resources/Notes

No response

github-actions[bot] commented 1 month ago

Hey @cjankowski23! Thanks for taking this issue.

To help keep everyone in the loop, please comment your Estimated Time to Completion (ETC) below!

Thanks again!

cjankowski23 commented 1 month ago

Found the final two paragraphs ("why" and the closing paragraph) in Figma:

Locations: Advice Page + Input Field Master Pages: Desktop Master Pages: Mobile

Shifted final line in all three locations.

Updated SOT on Google Docs Expunge Assist SOT

Hello @SamHyler the issue is ready for review.

github-actions[bot] commented 1 month ago

Hey @cjankowski23! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

cjankowski23 commented 3 weeks ago

Progress: Noticed when checking the Figma files sometimes the "Thank you for your consideration" statement was at the beginning of the why paragraphs, other times at the end of the why section. I audited the live form and messaged @SamHyler for clarification.

The line has now been shifted into its own closing line separate from the "Why" page.

Estimated Time to Completion (ETC): 1 week

Blockers: Messaged @anitadesigns and @jyehllow on slack to check spacing is visually correct on the master draft for mobile and desktop before handing off to Dev.

anitadesigns commented 2 weeks ago

I reviewed 2 frames (1 desktop and its mobile correspondent) and have questions for 2 other frames that I left on Figma! If those two frames add copy changes, I can review the padding once it is confirmed!

github-actions[bot] commented 1 week ago

Hey @cjankowski23! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

github-actions[bot] commented 2 days ago

Hey @cjankowski23! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!