Open nyarly opened 1 year ago
Looks like the ECR url is going to be static - I don't think that makes it as dynamic or machine generated.
Both the terraform documentation and the AWS ECR documentation point out that the url is of the form https://<:aws_account_id>.dkr.ecr.<:region-name>.amazonaws.com
Our account_id and region should rarely change. Nonetheless think we can wrap that url into a shared resource then reference that
What if any responsibility will ops have for this issue?
somewhat unclear here, but jason has a good point in that they are not precisely random or machine generated. could possibly be added as output to a project but tbd
@ale210 Please do not add things to the icebox in they have no defined dependency. Otherwise, we have to keep re-reading the issue over and over again to determine when to take it out of the icebox. Here are examples
Overview
Incubator projects use AWS Docker repositories with a machine-generated URL - a good sign that a resource should be added to Terraform.
Action Items
shared_resources
terraform state import
to bring the Registry under IaC managementpeople-depot-backend-dev:latest
) instead of hardcoding a machine-generated URL.Resources/Instructions
https://developer.hashicorp.com/terraform/language/state/import https://registry.terraform.io/providers/-/aws/latest/docs/resources/ecr_repository