hackforla / incubator

https://github.com/orgs/hackforla/projects/73/views/5
GNU General Public License v2.0
3 stars 14 forks source link

Create Terraform Plan GitHub action #31

Closed Tyson-miller closed 8 months ago

Tyson-miller commented 1 year ago

Overview

When we make changes to terraform modules it would be helpful to see the terraform plan as part of the PR so that people can confirm that the resources that would be created/modified/destroyed make sense.

Action Items

Resources/Instructions

https://github.com/marketplace/actions/terraform-plan - marketplace action for terraform plan https://github.com/marketplace/actions/changed-files - marketplace action for files changed

Tyson-miller commented 1 year ago

There is already a user in AWS called github-action-incubator with the secrets stored in the repo and the permissions to run terraform plan so step 1 and 2 should both be done

Tyson-miller commented 1 year ago

The only potentially tricky feature to implement will be detecting which terraform modules actually changed and running the terraform plan for each module that changed. For example, if someone makes changes to people-depot/dev, vrms-backend/dev, vrms-backend/live in one PR then the action should run the terraform plan for all of those directories.

Otherwise this is a pretty straightforward task

ExperimentsInHonesty commented 12 months ago

@Tyson-miller Please add a size label.

chelseybeck commented 8 months ago

Closed w/ this pr: https://github.com/hackforla/incubator/pull/30