search

hackforla / incubator

https://github.com/orgs/hackforla/projects/73/views/5
GNU General Public License v2.0
3 stars 14 forks source link

Automate running terraform docs 66 #67

Closed angela-lee1 closed 6 months ago

angela-lee1 commented 7 months ago

Fixes #66

We need to automate running Terraform Docs whenever a .tf file is changed inside of a Terraform directory. I have changed the region in terraform-incubator/people-depot/dev/main.tf to trigger. I will change back later.

angela-lee1 commented 7 months ago

@chelseybeck @freaky4wrld This is my first draft. Please take a look at it and give feedback for revision. Thank you.

freaky4wrld commented 7 months ago

@awlFCCamp I'm not that much experienced with terraform, but I can definitely review it if you provide me details what changes you've made. Or if @chelseybeck tells me where to start from :)

freaky4wrld commented 7 months ago

Hey @awlFCCamp I think the idea is to make changes to the terraform-plan.yml , and add the new GHA triggers to it... the file terraform-docs.yml looks fine to me. Moreover it can only be observed more when you have your test-environment ready for it!!

Though I'm not sure how you made changes to README.md of different projects, did you use terraform-docs to do it manually ?

angela-lee1 commented 7 months ago

@freaky4wrld Thank you! Chelsey suggested I put changes into a separate file for testing. I will ask her if I need to revert. I made all the changes through the terraform-docs.yml file. I set up testing in my branch, can you elaborate more on "when you have your test-environment ready for it!!" Sorry, My first GitHub action, I am excited but also a bit unsure.

freaky4wrld commented 7 months ago

@freaky4wrld Thank you! Chelsey suggested I put changes into a separate file for testing. I will ask her if I need to revert. I made all the changes through the terraform-docs.yml file. I set up testing in my branch, can you elaborate more on "when you have your test-environment ready for it!!" Sorry, My first GitHub action, I am excited but also a bit unsure.

I was asking if you have tested the GHA in your local repo, if it works fine in the local repo.... it will work here as well, this is the link to the guide in case you need it https://github.com/hackforla/website/wiki/Hack-for-LA's-GitHub-Actions

angela-lee1 commented 7 months ago

@freaky4wrld Thank you. It worked last week https://github.com/awlFCCamp/incubator/actions/runs/8725012627, but it failed here. I will look into it later today.

angela-lee1 commented 6 months ago

will make another one from a different branch