hackforla / internship

The Internship project provides an opportunity for students to work on open source projects in the fields of software, product development, project management, and UI/UX research and design at LA’s fastest growing Civic Tech non-profit organization during their summer.
GNU General Public License v2.0
17 stars 5 forks source link

TWE Design System Components: Update Buttons according to M3 #619

Open mklmrgn opened 2 months ago

mklmrgn commented 2 months ago

Overview

Change the Button Components to a more modern style based on Material Design 3.

Action Items

Resources/Instructions

Use Material Design (https://m3.material.io/) as guideline

KC-skc commented 1 month ago

@muntiCloud Please provide update

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
JaimeCucalon commented 1 month ago

This week I researched the M3 styling and approach. I learned that they have quite an extensive level of buttons and CTA elements that determine hierarchy for call to action. I'm wondering if we can narrow down the level of buttons before getting started. And focused on the common buttons.

Screenshot 2024-09-26 at 12 49 00 PM

vs

lvlz8hsu-1

I also studied the existing button master for the internship team. I believe it's minimal but not flexible enough. I would love to the discuss the complexity of buttons we want to keep for the project without adding too much work for future updates.

JaimeCucalon commented 1 month ago
  1. Progress:

    • Created 4 style of buttons following MD3 Specs and guidelines-Filled, outlined, text, and tonal.
    • Created icon variants for all 4 with boolean properties
  2. Blockers:

    • Researching if the pressed state is needed for our design system. It is very similar to the focused state, main difference is that it uses a ripple animation. Need to check with dev team to confirm feasibility.
    • Waiting on updated styles for icons, text, and button
    • Need to add icon variants to the design system. Color variants, and size variants
  3. Availability - 4 hours

  4. ETA: Hoping to have this component ready by end of next week

Screenshot 2024-10-10 at 10 14 14 AM

https://www.figma.com/design/TTRS2FWXsrymHYpPJL1IdH/Internship-Team-Main-file?node-id=6474-7596&t=dsy9ee4753S2UBxn-4

JaimeCucalon commented 3 weeks ago

Progress: Matched elevation, text size, icon size, and padding to MD3 design. There is one small icon/padding detail missing that needs addressing.

Blockers: Researching the use of different size buttons by MD3. So far research shows that common buttons use only one size. The FAB buttons are the only button components on the system that include 3 sizes, small, regular, and large - https://m3.material.io/components/floating-action-button/overview

Availability - 4 hours

ETA: Need another week.

Screenshot 2024-10-17 at 10 04 54 AM

https://www.figma.com/design/TTRS2FWXsrymHYpPJL1IdH/Internship-Team-Main-file?node-id=6474-7596&t=dsy9ee4753S2UBxn-4

JaimeCucalon commented 2 weeks ago

Progress:

Screenshot 2024-10-24 at 9 41 39 AM

Blockers:

Availability - 4 hours

ETA: Next Tuesday

JaimeCucalon commented 2 weeks ago

Made some additional changes to the button component colors in order to pass the color contrast requirements. The page includes two versions

@mklmrgn - Ready for review

Screenshot 2024-10-24 at 12 04 41 PM
JaimeCucalon commented 1 week ago

Progress:

Blockers: Need to determine if our color system requires different size buttons to create hierarchy for calls to action on the site. The new button system has 4 type of buttons; Filled, Outline, Tonal, and Text. This follows the MD3 system.

Screenshot 2024-10-31 at 9 47 10 AM

vs the current design system on the site that has 3 sizes, and doesn't follow the MD3 system closely.

Screenshot 2024-10-31 at 9 40 43 AM
JaimeCucalon commented 1 week ago

Notes from TWE on Button sizes: The discussion with Bonnie and Michael revealed that we have different button sizes because it follows the HFLA design system. That system showed that there are some large spaces where the primary call to action needs to be larger in order to fill the space for hero banners.

We decided to look into different sizes for the primary button only. Since that will be the button that gets featured the most. The secondary and tertiary button types will only have one size.

Here are the examples we reviewed that showed how both HFLA and MD3 use a similar approach.

Screenshot 2024-10-31 at 10 32 54 AM Screenshot 2024-10-31 at 10 24 29 AM