hackforla / lucky-parking

Visualization of parking data to assist in understanding of the effects of parking policies on a neighborhood by neighborhood basis in the City of Los Angeles
https://www.hackforla.org/projects/lucky-parking.html
34 stars 60 forks source link

Basic Modal Feature #534

Closed gibsonliketheguitar closed 1 year ago

gibsonliketheguitar commented 1 year ago

Description

Implement Modal Feature with Radix Dialog API

Related Issues

Resolves #529

Testing

 PASS  packages/website/src/widgets/header/header.test.tsx
 PASS  packages/ui/src/components/modal/modal.test.tsx

Test Suites: 2 passed, 2 total
Tests:       11 passed, 11 total
Snapshots:   0 total
Time:        15.76 s
Ran all test suites.
✨  Done in 17.03s.
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
ui/src/components/modal 56.25 100 50 56.25
modal.stories.tsx 0 100 0 0 2-35
modal.tsx 100 100 100 100

Checklist

netlify[bot] commented 1 year ago

Deploy request for lucky-parking-staging pending review.

Visit the deploys page to approve it

Name Link
Latest commit a567d012699697829dd044902e8fb8db8f04aa62
gibsonliketheguitar commented 1 year ago

Once this PR. I think we should squash commits?

glenflorendo commented 1 year ago

Once this PR. I think we should squash commits?

What do you mean "once this PR"?

gibsonliketheguitar commented 1 year ago

My bad, had a brain fart. I meant to say, "Once this PR is finished/ready"

glenflorendo commented 1 year ago

My bad, had a brain fart. I meant to say, "Once this PR is finished/ready"

Commits can be squashed before being merged. I think that's better, so we don't rewrite the history on our main branch.

netlify[bot] commented 1 year ago

Deploy Preview for lucky-parking-staging-storybook ready!

Name Link
Latest commit a567d012699697829dd044902e8fb8db8f04aa62
Latest deploy log https://app.netlify.com/sites/lucky-parking-staging-storybook/deploys/64cfd9e465d3010008606dae
Deploy Preview https://deploy-preview-534--lucky-parking-staging-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.