hackforla / lucky-parking

Visualization of parking data to assist in understanding of the effects of parking policies on a neighborhood by neighborhood basis in the City of Los Angeles
https://www.hackforla.org/projects/lucky-parking.html
34 stars 60 forks source link

Implement PickList Component #543

Closed gibsonliketheguitar closed 1 year ago

gibsonliketheguitar commented 1 year ago

Description

PickList's width by default fills to parent container and allows developers to insert custom width if needed.

Related Issues

Resolves #522

Testing

 PASS  packages/website/src/widgets/header/header.test.tsx
 PASS  packages/ui/src/components/modal/modal.test.tsx
 PASS  packages/website/src/widgets/header/how-it-works-button.test.tsx
 PASS  packages/ui/src/components/pick-list/pick-list.test.tsx (5.029 s)

Test Suites: 4 passed, 4 total
Tests:       29 passed, 29 total
Snapshots:   0 total
Time:        15.214 s
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
.../pick-list 47.82 100 28.57 50
pick-list-test-data.ts 100 100 100 100
pick-list.tsx 100 100 100 100

Checklist

gibsonliketheguitar commented 1 year ago

Should my test report include stories.tsx and etc?

.../pick-list | 47.82 | 100 | 28.57 | 50 |
index.ts | 0 | 100 | 0 | 0 | 1
...t-data.ts | 100 | 100 | 100 | 100 |
...ories.tsx | 0 | 100 | 0 | 0 | 2-36
...-list.tsx | 100 | 100 | 100 | 100 |

gibsonliketheguitar commented 1 year ago

Reason why we are seeing

@gibsonliketheguitar feat(ui): add additional modal properties d2cad42 @gibsonliketheguitar feat(website): implement modal for how-it-works-button 7716ca6

again. Is because yesterday I notice my email wasn't attached to my git. I fixed that and also squashed the commit.

netlify[bot] commented 1 year ago

Deploy Preview for lucky-parking-staging canceled.

Name Link
Latest commit c181165e8c16489c8ef9b00468eff422a9f641f1
Latest deploy log https://app.netlify.com/sites/lucky-parking-staging/deploys/64e53939ae429900084c486b
netlify[bot] commented 1 year ago

Deploy Preview for lucky-parking-staging-storybook canceled.

Name Link
Latest commit c181165e8c16489c8ef9b00468eff422a9f641f1
Latest deploy log https://app.netlify.com/sites/lucky-parking-staging-storybook/deploys/64e5393976dba6000893407f
glenflorendo commented 1 year ago

@gibsonliketheguitar I'm not able to merge this PR in. Could you rebase and push this in, again?