Closed bennyv8 closed 10 months ago
Name | Link |
---|---|
Latest commit | fe0e0969dfeba0cb45bcc6e04c7577734c307c74 |
Latest deploy log | https://app.netlify.com/sites/lucky-parking-staging/deploys/6529a7c6521b7f0008663ac9 |
Deploy Preview | https://deploy-preview-562--lucky-parking-staging.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | fe0e0969dfeba0cb45bcc6e04c7577734c307c74 |
Latest deploy log | https://app.netlify.com/sites/lucky-parking-staging-storybook/deploys/6529a7c67615d900082b14b4 |
Great work on this!
Converted site.webmanifest to manifest.json. Found conflicting information on which is best to use despite no notable difference in functionality. Went with .json due to it being more common/conventional overall.
I concur with your decision. It aligns with what I briefly researched, and I like your reasoning for choosing the JSON path.
I didn't write tests for the favicon, if I should, where should I put the file. Additionally where might I find the documentation process
I think your manual testing works well for now. No need to overcomplicate this.
Description
Should load and display favicon in every environment
Converted site.webmanifest to manifest.json. Found conflicting information on which is best to use despite no notable difference in functionality. Went with .json due to it being more common/conventional overall.
Related Issues
Resolves #553
Testing
Checklist
I didn't write tests for the favicon, if I should, where should I put the file. Additionally where might I find the documentation process