Upload favicon

[bennyv8]

Description

Should load and display favicon in every environment

• Uploaded the six favicon and manifest files in /public
• Added icons, name, and start_url to site.webmanifest -> manifest.json file
• Updated index.html with appropriate favicon and manifest link tags

Converted site.webmanifest to manifest.json. Found conflicting information on which is best to use despite no notable difference in functionality. Went with .json due to it being more common/conventional overall.

Related Issues

Resolves #553

Testing

• Ran testing suites.
• Checked for Favicon on Chrome, Edge, and FireFox browser

Checklist

• [x] I have followed all conventions outlined in our documentation.
• [x] I have fully tested my changes and confirmed that all new and existing tests pass.
• [x] I have written meaningful commit messages for all changes.
• [x] I have linted and formatted my changes to follow the code style of this repository.
• [ ] I have updated our documentation, accordingly.
• [x] I have checked currently opened pull requests to ensure that there are no pending pull request for the same changes or issues.
• [x] I have confirmed that this pull request fully meets the acceptance criteria for all related issues listed above.

I didn't write tests for the favicon, if I should, where should I put the file. Additionally where might I find the documentation process

[netlify[bot]]

✅ Deploy Preview for lucky-parking-staging ready!

Name	Link
🔨 Latest commit	fe0e0969dfeba0cb45bcc6e04c7577734c307c74
🔍 Latest deploy log	https://app.netlify.com/sites/lucky-parking-staging/deploys/6529a7c6521b7f0008663ac9
😎 Deploy Preview	https://deploy-preview-562--lucky-parking-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify[bot]]

✅ Deploy Preview for lucky-parking-staging-storybook canceled.

Name	Link
🔨 Latest commit	fe0e0969dfeba0cb45bcc6e04c7577734c307c74
🔍 Latest deploy log	https://app.netlify.com/sites/lucky-parking-staging-storybook/deploys/6529a7c67615d900082b14b4

[glenflorendo]

Great work on this!

Converted site.webmanifest to manifest.json. Found conflicting information on which is best to use despite no notable difference in functionality. Went with .json due to it being more common/conventional overall.

I concur with your decision. It aligns with what I briefly researched, and I like your reasoning for choosing the JSON path.

I didn't write tests for the favicon, if I should, where should I put the file. Additionally where might I find the documentation process

I think your manual testing works well for now. No need to overcomplicate this.