Refactor radio group to UI library

bennyv8 commented 9 months ago

Description

Refactored radio-group UI moving it to the UI library Added test suite to test rendering and option selection Added Radio-Group to the storybook library

Notes:

{ onEvent } import in "/radio-group" and "/radio-options" references the "/types" in the previous Website directory. I noticed there was a types folder in the UI directory but unsure if it was relevant to add a onEvent type declaration there.
Unable to simulate click event with userEvent.click() for some reason. I tried awaiting the click and the state change and tried different ways to reference the element. Ultimately couldn't figure out why the radio-option didn't update on click.

Related Issues

Resolves #590

Testing

Wrote test to mimic option selection by users as well as rendering
Ran testing suites.

Checklist

[x] I have followed all conventions outlined in our documentation.
[x] I have fully tested my changes and confirmed that all new and existing tests pass.
[x] I have written meaningful commit messages for all changes.
[x] I have linted and formatted my changes to follow the code style of this repository.
[ ] I have updated our documentation, accordingly.
[x] I have checked currently opened pull requests to ensure that there are no pending pull request for the same changes or issues.
[x] I have confirmed that this pull request fully meets the acceptance criteria for all related issues listed above.

netlify[bot] commented 9 months ago

Deploy Preview for lucky-parking-staging ready!

Name	Link
Latest commit	b0b292b3267877ffcd2448d3bc35bc26a980ae84
Latest deploy log	https://app.netlify.com/sites/lucky-parking-staging/deploys/655411eceb341c000811c36a
Deploy Preview	https://deploy-preview-593--lucky-parking-staging.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 9 months ago

Deploy Preview for lucky-parking-staging-storybook ready!

Name	Link
Latest commit	b0b292b3267877ffcd2448d3bc35bc26a980ae84
Latest deploy log	https://app.netlify.com/sites/lucky-parking-staging-storybook/deploys/655411ece484c90008649aab
Deploy Preview	https://deploy-preview-593--lucky-parking-staging-storybook.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

glenflorendo commented 9 months ago

@bennyv8

Looks like we're importing types from the website package. We want to avoid circular dependencies.

I'll create another package called types, so we can store our shared types there, since there is overlap between the ui and website package. Let's hold off merging this until that is set up, so we can update your PR.

Also, it looks like there are merge conflicts. Could you take a look at those?

glenflorendo commented 9 months ago

@bennyv8

Looks like we're importing types from the website package. We want to avoid circular dependencies.

I'll create another package called types, so we can store our shared types there, since there is overlap between the ui and website package. Let's hold off merging this until that is set up, so we can update your PR.

Also, it looks like there are merge conflicts. Could you take a look at those?

Actually, let's just move forward with this. I don't want to block you. I can make the changes myself later.

hackforla / lucky-parking