Closed bennyv8 closed 9 months ago
Name | Link |
---|---|
Latest commit | b0b292b3267877ffcd2448d3bc35bc26a980ae84 |
Latest deploy log | https://app.netlify.com/sites/lucky-parking-staging/deploys/655411eceb341c000811c36a |
Deploy Preview | https://deploy-preview-593--lucky-parking-staging.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | b0b292b3267877ffcd2448d3bc35bc26a980ae84 |
Latest deploy log | https://app.netlify.com/sites/lucky-parking-staging-storybook/deploys/655411ece484c90008649aab |
Deploy Preview | https://deploy-preview-593--lucky-parking-staging-storybook.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@bennyv8
Looks like we're importing types from the website
package. We want to avoid circular dependencies.
I'll create another package called types
, so we can store our shared types there, since there is overlap between the ui
and website
package. Let's hold off merging this until that is set up, so we can update your PR.
Also, it looks like there are merge conflicts. Could you take a look at those?
@bennyv8
Looks like we're importing types from the
website
package. We want to avoid circular dependencies.I'll create another package called
types
, so we can store our shared types there, since there is overlap between theui
andwebsite
package. Let's hold off merging this until that is set up, so we can update your PR.Also, it looks like there are merge conflicts. Could you take a look at those?
Actually, let's just move forward with this. I don't want to block you. I can make the changes myself later.
Description
Refactored radio-group UI moving it to the UI library Added test suite to test rendering and option selection Added Radio-Group to the storybook library
Notes:
Related Issues
Resolves #590
Testing
Checklist