hackforla / lucky-parking

Visualization of parking data to assist in understanding of the effects of parking policies on a neighborhood by neighborhood basis in the City of Los Angeles
https://www.hackforla.org/projects/lucky-parking.html
34 stars 60 forks source link

Test enum utilities #605

Closed glenflorendo closed 9 months ago

glenflorendo commented 9 months ago

Description

This PR provides complete testing of the enum utility functions.

Enum Utilities
    getNth
      ✓ gets the nth enum (2 ms)
      ✓ returns undefined for out-of-bounds nth
    getFirst
      ✓ gets first enum
      ✓ returns undefined for empty enum

Related Issues

Resolves #586

Testing

-----------------------------------------------|---------|----------|---------|---------|-----------------------
File                                           | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s     
-----------------------------------------------|---------|----------|---------|---------|-----------------------
 src/shared/lib/utilities                      |   24.13 |        0 |   33.33 |      15 |                       
  enum.ts                                      |     100 |      100 |     100 |     100 |                       

Checklist

netlify[bot] commented 9 months ago

Deploy Preview for lucky-parking-staging ready!

Name Link
Latest commit b9de242440c5cf102f9bb3fbd103bc96e53e96fc
Latest deploy log https://app.netlify.com/sites/lucky-parking-staging/deploys/65666d3ba835c70008ee78db
Deploy Preview https://deploy-preview-605--lucky-parking-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 9 months ago

Deploy Preview for lucky-parking-staging-storybook canceled.

Name Link
Latest commit b9de242440c5cf102f9bb3fbd103bc96e53e96fc
Latest deploy log https://app.netlify.com/sites/lucky-parking-staging-storybook/deploys/65666d3beb29dd00088c0087
glenflorendo commented 9 months ago

Fixed merge conflicts.