Added fallback loader for citation-data-insights

hackforla / lucky-parking

Visualization of parking data to assist in understanding of the effects of parking policies on a neighborhood by neighborhood basis in the City of Los Angeles

https://www.hackforla.org/projects/lucky-parking.html

34 stars 59 forks source link

Added fallback loader for citation-data-insights #622

Closed bzzz-coding closed 4 months ago

bzzz-coding commented 4 months ago

Description

Implemented a circular loader component
Wrapped citation-data-insights with a loader

Related Issues

Resolves #619

Testing

Ran testing suites.

Checklist

[x] I have followed all conventions outlined in our documentation.
[x] I have fully tested my changes and confirmed that all new and existing tests pass.
[x] I have written meaningful commit messages for all changes.
[x] I have linted and formatted my changes to follow the code style of this repository.
[x] I have updated our documentation, accordingly.
[x] I have checked currently opened pull requests to ensure that there are no pending pull request for the same changes or issues.
[x] I have confirmed that this pull request fully meets the acceptance criteria for all related issues listed above.

bzzz-coding commented 4 months ago

Hi @glenflorendo , I was going through the checklist and wonder if and where I should update our documentation regarding this PR. I'm also not sure if adding tests for the Loader component is enough. Should I add more tests to citation-data-insights before changing this PR from draft to reday-for-review? Thank you!

glenflorendo commented 4 months ago

Hi @glenflorendo , I was going through the checklist and wonder if and where I should update our documentation regarding this PR. I'm also not sure if adding tests for the Loader component is enough. Should I add more tests to citation-data-insights before changing this PR from draft to reday-for-review? Thank you!

Great questions!

Documentation can mean many things. It could be updating our wiki, READMEs, or even just documenting your code using JSDoc. I'm not so strict on this right now. I trust your instincts as a developer.

glenflorendo commented 4 months ago

The loader tests are good for now! We can always expand later. 👍🏽

netlify[bot] commented 4 months ago

Deploy Preview for luckyparking ready!

Name	Link
Latest commit	6d28c73db5824b86b32f757aba3efc67253b51c7
Latest deploy log	https://app.netlify.com/sites/luckyparking/deploys/65e015b4755d410008164599
Deploy Preview	https://deploy-preview-622--luckyparking.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.