GHPAGES-DOCKER needs to be updated

hackforla / ops

A repository for the OPS Community of Practice

https://github.com/orgs/hackforla/projects/73

MIT License

8 stars 7 forks source link

GHPAGES-DOCKER needs to be updated #137

Open gaylem opened 1 month ago

gaylem commented 1 month ago

GitHub Pages is now using v232 of the GitHub Pages Ruby Gem. You are using v231. Please refer to the ghpages-docker Wiki for instructions on how to update.

fyliu commented 1 month ago

I see #141 saying the gem is at v227 now. Did someone rebuild the image recently?

Would anyone mind if I clicked the button to see if it updates it like the instructions say?

I'll add a note and leave this alone if it takes much more than that, but I doubt it.

Update: it's definitely on pre-v229 if the ruby version is 2.7 . Here's the v229 changes where the ruby version went from 2.7.3 to 3.3

danielridgebot commented 4 weeks ago

Hi @fyliu this is @roslynwythe co-lead of the website team, and I generated #141 and #142 I am not aware of the image being rebuilt recently but it should be rebuilt to update the versions of the ruby and gh-pages gems.

I'm not sure what you mean by

Would anyone mind if I clicked the button to see if it updates it like the instructions say?

I don't know how the ops team works but would you or someone else be interested in working on these issues? If not, I would be willing to self-assign follow the instructions in https://github.com/hackforla/ghpages-docker/wiki#how-do-you-update-ghpages-docker (in my fork) then create a PR?

fyliu commented 4 weeks ago

Hi @roslynwythe I just commented because it looks like it wouldn't take too long to resolve (I hope). I think it's better that you did this if you're willing. I had a small part when Eric worked on the code to create the docker image, so I'm somewhat familiar with it. I'd be good if more people become familiar with it.

I guess the instructions on updating the gem by clicking the "Run workflow" button to trigger the workflow-dispatch won't work for this case because the gem now depends on a much newer ruby and that requires updating the code to rebuild the image.

I don't think I have write access to that repo, but if you create a PR that needs review, I can maybe ask for temporary permission? It feels like at least the website team leads should get write access to it.

danielridgebot commented 3 weeks ago

@fyliu this is @roslynwythe logged in as danielridgebot and I am willing to take #142 and as you mention, it will require updating the code to rebuild the image. We also have #141 and I believe that can be closed, because when the image is rebuild, the latest version of the github pages gem will be included. Please correct me if that is incorrect.

fyliu commented 3 weeks ago

@roslynwythe that sounds right to me according to the update documentation. The gem should be automatically updated when the image is rebuilt. The only thing that needs doing seems to be updating the ruby images in the Dockerfile.