search

hackforla / peopledepot

A project to setup a datastore for people and projects at HackforLA. The link below takes you to the code documentation
https://hackforla.github.io/peopledepot/
GNU General Public License v2.0
5 stars 24 forks source link

Create table language 54 #195

Closed AzaniaBG closed 9 months ago

AzaniaBG commented 10 months ago

@fyliu ~ this is a backup I created after we squashed commits and rebased HfLA's main commits on top of the language feature branch. I think this should work. If this is acceptable, I will add the precommit checks.

AzaniaBG commented 10 months ago

Thanks, @fyliu. I may not understand your goals for "clean" commits and would like to discuss to improve my commits moving forward. Also, is this something you want to try to address in the Contributing guide?

fyliu commented 9 months ago

Oh the branch got deleted.

I think we left this too long and didn't have the discussion that was referred to above.

I have a copy of that branch so I'll do the git manipulations and merge it into main. The overall code changes will be exactly the same but with different commits. They'll all have you as the author.

fyliu commented 9 months ago

I manually pushed the commits to main. Here are the changes I made:

  1. moved the script fix commit to the beginning, but separated the 0014 migration file from that commit since it belonged with the language feature.
  2. squashed all the other commits into the feature commit and added the 0014 migration file
  3. added new short messages to the commits and moved the original messages into the descriptions