hackforla / peopledepot

A project to setup a datastore for people and projects at HackforLA. The link below takes you to the code documentation
https://hackforla.github.io/peopledepot/
GNU General Public License v2.0
5 stars 24 forks source link

Create prod Dockerimage from alpine base image #222

Closed alexlaw528 closed 2 months ago

alexlaw528 commented 8 months ago

Fixes #177

What changes did you make?

Why did you make the changes (we will use this info to test)?

Deploy prod environment locally

fyliu commented 8 months ago

@alexlaw528 I think the "alpine" is usually part of the image tags. Like -t pd:latest-alpine

I'm not sure if there's a best practice for managing dev and prod dockerfiles. I see some people do Dockerfile.prod, or use the same Dockerfile for both with conditionals. I guess putting it in a directory is as good as any. We can think about this later.

We should also do multistage build to maybe avoid part of the 211MB that system dependencies take up. This is just a note for a later issue.

ExperimentsInHonesty commented 2 months ago