hackforla / peopledepot

A project to setup a datastore for people and projects at HackforLA. The link below takes you to the code documentation
https://hackforla.github.io/peopledepot/
GNU General Public License v2.0
5 stars 24 forks source link

User login page (KB requirement) #241

Closed fyliu closed 1 day ago

fyliu commented 5 months ago

Overview

We need to implement the ability for users to login directly to the PD backend to support KB functions.

Description is based on work @ethanstrominger already did in a branch.

Action Items

Resources/Instructions

fyliu commented 5 months ago

@ethanstrominger already has this working.

There's a security feature (client_secret) that needed to be disabled because it was difficult to make it work. Right now it runs fine without using client_secret.

Question: I'm not sure what milestone this should be under. It relates to KB but it's not a "create table issue"

ExperimentsInHonesty commented 1 month ago

@fyliu I added the milestone initial setup. Can this issue be closed?

fyliu commented 1 month ago

@ExperimentsInHonesty The code is not merged yet.

This is an issue I created to attempt to describe part of @ethanstrominger 's code changes in the draft PR that contains other changes. We created and merged a separate PR from part of the changes but the code for this is still in that draft PR and needs separating out and cleaned up to merge.

Question

The changes in the PR skips it because it returned an error when Ethan tried it with the option but it did work without it. I created #242 to fix it separately just in case the PR gets merged without it. Cognito docs says we should be using it. See the Confidential client section.

Note

Recently, I learned that client_secret is essentially an "API Key" that identifies a client to Cognito login.

fyliu commented 1 month ago

I'm not sure what the status of this issue is since the PR #234 is closed. @ethanstrominger is this issue still going to be implemented?