Closed freaky4wrld closed 1 month ago
@fyliu the changes you suggested are done, except the one with the is_sponsor
one.
@fyliu the changes requested are done please check
I'm realizing that this PR is essentially ready and is actually waiting for me.
We were discussing changes to it over slack chat. I'm pasting that here for reference
project_affiliate_xref
Affiliation
, specifying that the db_table
is the name abovesponsor
or partner
sponsor_partner
table name to affiliate
and the FK field in Affiliation
I need to create issues for these and you can make any of the changes here you feel makes sense.
@fyliu I've made the suggested change, have a look and do resolve the issue I've mentioned in slack!!
@fyliu renamed the model and implemented Python Enums as per requirement, please check.
@freaky4wrld I just realized that the boolean to enum change hasn't been agreed on with @Neecolaa yet. Will have to bring that up for discussion in the next meeting.
@freaky4wrld I just realized that the boolean to enum change hasn't been agreed on with @Neecolaa yet. Will have to bring that up for discussion in the next meeting.
@fyliu did you had the discussion with @Neecolaa. I'm still waiting for the confirmation and further info on changes to be made!!
We're adding a row:
is_partner
is a boolean that indicated whether or not the given affiliate is a partner for the given project. Projects can now have an affiliate be both a partner and sponsor. We now have definitions for the affiliate types as well:
A Partner is an entity that's doing ongoing work with us on the project.
A sponsor is someone who has provided funds or an in-kind donation.
We won't be using an enum, just the two booleans.
@freaky4wrld see update comment above
@fyliu and @Neecolaa the changes have been made as suggested, please check and provide feedback Thanks
Fixes #65 , #272
What changes did you make?
Created a model for the
ProjectSponsorPartnerXref
Registered the model to adminSite
Created API endpoints
Renamed the model
sponsor_partner
toaffiliate
Why did you make the changes (we will use this info to test)?
To add a table
ProjectSponsorPartnerXref
in the databaseTo make the model name shorter to
affiliate