hackforla / peopledepot

A project to setup a datastore for people and projects at HackforLA. The link below takes you to the code documentation
https://hackforla.github.io/peopledepot/
GNU General Public License v2.0
5 stars 24 forks source link

Create table project_sponsor_partner_xref #270

Closed freaky4wrld closed 1 month ago

freaky4wrld commented 3 months ago

Fixes #65 , #272

What changes did you make?

freaky4wrld commented 3 months ago

@fyliu the changes you suggested are done, except the one with the is_sponsor one.

freaky4wrld commented 3 months ago

@fyliu the changes requested are done please check

fyliu commented 2 months ago

I'm realizing that this PR is essentially ready and is actually waiting for me.

We were discussing changes to it over slack chat. I'm pasting that here for reference

I need to create issues for these and you can make any of the changes here you feel makes sense.

freaky4wrld commented 2 months ago

@fyliu I've made the suggested change, have a look and do resolve the issue I've mentioned in slack!!

freaky4wrld commented 2 months ago

@fyliu renamed the model and implemented Python Enums as per requirement, please check.

fyliu commented 2 months ago

@freaky4wrld I just realized that the boolean to enum change hasn't been agreed on with @Neecolaa yet. Will have to bring that up for discussion in the next meeting.

freaky4wrld commented 2 months ago

@freaky4wrld I just realized that the boolean to enum change hasn't been agreed on with @Neecolaa yet. Will have to bring that up for discussion in the next meeting.

@fyliu did you had the discussion with @Neecolaa. I'm still waiting for the confirmation and further info on changes to be made!!

Neecolaa commented 2 months ago

We're adding a row: is_partner is a boolean that indicated whether or not the given affiliate is a partner for the given project. Projects can now have an affiliate be both a partner and sponsor. We now have definitions for the affiliate types as well: A Partner is an entity that's doing ongoing work with us on the project. A sponsor is someone who has provided funds or an in-kind donation.

We won't be using an enum, just the two booleans.

Neecolaa commented 2 months ago

@freaky4wrld see update comment above

freaky4wrld commented 1 month ago

@fyliu and @Neecolaa the changes have been made as suggested, please check and provide feedback Thanks