hackforla / shared-housing

LA Family Housing, an LA-based non-profit working to end the homelessness crisis, engaged the help of Hack for LA to identify and design a more efficient & effective solution for matching multiple individuals who experience homelessness as potential co-tenants, and placing the matched individuals in suitable shared housing units.
https://www.hackforla.org/
GNU General Public License v3.0
29 stars 29 forks source link

Fix Linkedin bug in Team Roster #212

Open itsevalieu opened 4 years ago

itsevalieu commented 4 years ago

Get the LinkedIn icons/links, include the material-ui icons. You'll need to install material-ui icon packages.

wsbuck commented 4 years ago

@kennethlee I assigned you to this. Let me know if you run into any trouble again. I know you mentioned an issue with the icons before. I thought it had to do with material-ui/icons being a seperate package from material-ui/core but it looks like we already have the icons package downloaded.

kennethlee commented 4 years ago

@wsbuck Yeah I tried using other icons from the m-ui/icons lib and they worked just fine, it was specifically only the linkedin icon that didn't work (strange).

Anyway, I've been troubleshooting some frustrating dev environment issues on my machine since yesterday but will get to this after that is ironed out. Feel free to assign me others in the meantime; otherwise, I'll take a look at the outstanding issues and pick a couple up later.

karlmageddon commented 4 years ago

It might have something to do with the version of m-ui/icons we currently have. Maybe updating it will yield the LI icon?

kennethlee commented 4 years ago

@wsbuck @karlmageddon reached out to me wondering if he could take a crack at making aesthetic improvements to the team roster; perhaps we should assign this issue to him instead?

ExperimentsInHonesty commented 4 years ago

@karlmageddon are you still working on this, and if so what has been done? Sent slack message as well.