hackforla / tdm-calculator

DTLA Hack for LA is partnering with Los Angeles Department of Transportation (LADOT) to develop a Traffic Demand Management (TDM) calculator tool. This tool will help planners at LADOT and real estate developers to meet the Los Angeles’s Mobility Plan goals by 2035.
https://tdm.ladot.lacity.org
GNU General Public License v2.0
45 stars 27 forks source link

Restructure withToastProvider HOC for testability #973

Open fyliu opened 2 years ago

fyliu commented 2 years ago

Dependency

Overview

We need to use the same code that can implement Toasts consistently through out the app.

Detail

Action Items

Resources/Instructions

KPHowley commented 2 years ago

@fyliu - I would love to see @seenaiype and our UI/UX teams thought on toast's in general before adding this to the backlog- They are been working on an new style guide / Audit so I'm going to add #536 and #972 as blockers on this.

Biuwa commented 1 year ago

From John:

'From the comments, it looks like Kevin Howley was hoping that the style guide would include a new wireframe for how toasts look, so made this issue dependent upon the design system effort at the time. Toasts are the little messages that show up and then disappear after a few seconds that you see on some of the screens. I agree that they look sort of crude, and, if I recall correctly, the different toast appear in various different locations on the screen - so they probably could look better. Issue #973 is just about changing the way the code for toasts is written to reduce duplication of code and make the code to implement each different toast simpler - it sort of falls under the heading of "code cleanup"'