hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
325 stars 759 forks source link

Standardize Events page: add section container without restricting banner #1125

Closed daniellex0 closed 3 years ago

daniellex0 commented 3 years ago

Overview

We want to add a section container (class .content-section) to the Events page body to keep this page consistent with other pages on the HfLA website.

This container ensures that the page has the standard 16px margin in mobile view. However, it adds the margin to the yellow covid warning banner as well, and we want that component to stay full-screen width if possible.

Action Items

Resources/Instructions

Events page

This is how the banner looks with the .content-section class, without any edits (it should instead be full-width, without the purple margins on the sides):

Screen Shot 2021-02-25 at 8 58 50 PM
evancchen commented 3 years ago

image Is this ok?

evancchen commented 3 years ago

image This is how it used to look

daniellex0 commented 3 years ago

@evancchen Hi Evan, the yellow looks like it goes all the way to the edges of the screen, so that's good. The only issues are that the pink arrow and icon are a little too pushed up to the edges, the paragraph text is a little too crowded in the middle, and it looks like there is white area around the palm tree photo for some reason.

It should look more like it looks on the site right now, so like this:

Screen Shot 2021-03-21 at 2 35 02 AM

I'm sorry, I know this issue is kind of a pain and won't really make a difference to the way the page looks- it's just for standardizing the CSS on all of the pages.

If it's overly complicated, we could just leave out the .content-section class from this page for now and leave this issue in the ice box to be honest.

So feel free to skip out on this issue and choose another one if you prefer!