hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
324 stars 762 forks source link

Develop Wins page #162

Closed alecg123 closed 3 years ago

alecg123 commented 4 years ago

Overview

Wins Page will document our project successes as well as individual team members 'growth+development+and achievements'; including new hires and skills.

One of our HackForLA Website Update Objectives is to “Present a clear and compelling value proposition for participants in projects.” Essentially what can a volunteer get out of volunteering for Hack for LA?

Action Items

Resources/Instructions

see this comment for details about the type of checkboxes https://github.com/hackforla/website/issues/162#issuecomment-636576691

Secrets issue https://github.com/hackforla/website/issues/98

Important links

Mr/Hack-for-LA-Website?node-id=1284%3A102)

ExperimentsInHonesty commented 4 years ago

@alecg123 said: We might advertise on this page:

ExperimentsInHonesty commented 4 years ago

I got a new job I produced something for my portfolio I improved my linkedin I learned how to work better on a team I increase the number of commits on my github profile I learned a new language I became proficient at github I setup 2FA I worked on an enterprise project I worked on a project that will help the people of Los Angeles I worked on two projects I taught or mentored another person on my team I taught or mentored a person on another team My team delivered software to a stakeholder My team launched our MVP Other ___

Tell us about it:

Can we use your linkedin picture next to your story linkedin:

Name:

ExperimentsInHonesty commented 4 years ago

catagories:

Business Analyst PM Content UI/UX Development Ops Data other QA SEO/Marketing

leestella748 commented 4 years ago

Figma: https://www.figma.com/file/0RRPy1Ph7HafI3qOITg0Mr/Hack-for-LA-Website?node-id=1284%3A102

@ExperimentsInHonesty

  1. I didn't fully format the survey page since it'll be an embedded Google form, but let me know if I'm missing anything.

  2. For the wins page, I think a 2-column layout works better than a 1-column layout and makes the list look more robust. If we want to add copy up top I can do that as well.

image
ExperimentsInHonesty commented 4 years ago

more link modal on the full screen accordion on the mobile

adding in soundbite field add github url field if no linkedin url provided dont ask them for linkedin photo usage people can choose either or github/linkedin

alexandrastubbs commented 4 years ago

@leestella748 ETA is EOD 7/5

leestella748 commented 4 years ago

@ExperimentsInHonesty @alexandrastubbs Here's the Figma link: https://www.figma.com/file/0RRPy1Ph7HafI3qOITg0Mr/Hack-for-LA-Website?node-id=1552%3A3693

image
alexandrastubbs commented 4 years ago

Add the following teams to the Figma:

alexandrastubbs commented 4 years ago

@leestella748 as we are building out the google form, we'd like to add an image at the top that corresponds to the image we have on the page. The image size is 1600x400. An example of an existing survey is: https://docs.google.com/forms/u/1/d/e/1FAIpQLSfb8IOV1oHhWCMPedZFJ0cl35Q3haomR8xMNRt2QXCEuVPwtw/viewform

alexandrastubbs commented 4 years ago

Work in progress form can be found here

embed code for show us your wins (for later date): <iframe src=“https://docs.google.com/forms/d/e/1FAIpQLScQPxxJ6lekzqWpi3hyV-yiSMxKagf8lS7zxArKbqbsgb079A/viewform?embedded=true” width=“640" height=“549” frameborder=“0" marginheight=“0” marginwidth=“0">Loading…

alexandrastubbs commented 4 years ago
  1. Progress - form not started yet
  2. Blocks - none
  3. Availability - Mon, Tues, Wed
  4. ETA - Tuesday EOD
leestella748 commented 4 years ago

wins-2

alexandrastubbs commented 4 years ago

Google form is complete here. Open to suggestions and/or edits. @ExperimentsInHonesty

jbubar commented 4 years ago

Progress: created the two pages. started styling them. blocks: could not figure out how to style the embedded google form. problems that I think I will run into: I have not figure out how to link the responses to the google form yet. I also have no idea how to make a modal open up when the user clicks on "see more" eta: next week availability: will be working on this all week

jbubar commented 4 years ago

https://drive.google.com/drive/folders/1Yglu0ehQQu2hhjd0Rf6AS1sPlNvPHnay Above is the link to the google drive folder with the google form and google sheet containing the responses.

I do not think I can finish this issue in a timely manner, and it is probably best to pass it on to someone else. :). My apologies for taking two weeks and not having it done yet.

ExperimentsInHonesty commented 4 years ago

Link the form to the page (don't do an iframe for the mvp https://docs.google.com/forms/d/e/1FAIpQLSdF0MgS-M_Soi77qTp-MNfxMGqq85yqsHwvfHDngHAMyDQ8uQ/viewform

jbubar commented 4 years ago

progress: no progress blocks: Efren and I did not find a time to meet, and I was super busy this last week ETA: next week availability: late mornings and early afternoons during the week.

alexandrastubbs commented 4 years ago

@ruben1s to connect with @jbubar on this

efrenmarin45 commented 4 years ago

Progress: Coordinated with @jbubar to go over blocks and outcomes. Went over possible workarounds for the API and went over some examples on how to do it. Blocks: Need to find out the most optimal solution to implement google sheets API onto site. Availability: Limited, due to illness. ETA: Ongoing

ExperimentsInHonesty commented 4 years ago

@jbubar Have you read this? https://medium.com/better-programming/make-a-team-roster-with-node-react-and-google-sheets-305b9f9ebbb1 Did you find it of any help?

jbubar commented 4 years ago

But I thought we were trying not to use node.js

jbubar commented 4 years ago

screencapture-localhost-4000-wins-page-html-2020-08-29-10_22_02 Progress: I got it working with live data!! I have yet to style it and add the github and linkedin api call for the photos. I am working with efren and raudel.

Blocks: A few things that I am still unsure about is showing the api key, the fact that I am using my personal google account, and if it will work on anyone elses machine. But I think raudel and I will work that out today at 12pm.

ETA: our meeting tomorrow, sunday at 10am (fingers crossed) Availability: from now until the meeting tomorrow

jbubar commented 4 years ago

I was also thinking, that maybe we could do something like this for the mvp. Since, I am still figuring out the google sheets api (the photos are of the desktop, tablet, and mobile views) screencapture-localhost-4000-wins-page-html-2020-08-29-11_03_44

screencapture-localhost-4000-wins-page-html-2020-08-29-11_05_00 screencapture-localhost-4000-wins-page-html-2020-08-29-11_08_46

ExperimentsInHonesty commented 4 years ago

Temporary image to use on the MVP of the wins page: noun_person_2024954-scalled_to_500x500

link for noun project page https://thenounproject.com/search/?=2024954 attribution text: person by amantaka from the Noun Project

I also slacked the SVG in case you needed it.

The images coming from Linked in are going to be 500x500

jbubar commented 4 years ago

screencapture-0-0-0-0-4000-wins-page-html-2020-09-04-14_05_35

Progress: That is how the page looks for now.

Blocks: Still working on the secrets. Need to figure out a system for the secrets. Using my api key. Not sure why Bonnie's api key is not working for me. Have not started with github api for photos.

Availability and eta: I had a pretty bust week this week. I do not know if I will get the secrets thing done in time for the meeting on sunday. But I will put in a 4-5 hours tomorrow

ExperimentsInHonesty commented 4 years ago

This is the setup that Josh Has

Screen Shot 2020-09-04 at 5 14 01 PM



oath screen Screen Shot 2020-09-04 at 3 52 08 PM



Screen Shot 2020-09-04 at 5 15 24 PM

This is the setup I have in the account tied to hackforla-bot@hackforla.org screencapture-console-developers-google-apis-credentials-consent-edit-2020-09-04-17_24_04

As you can see, I don't have any

efrenmarin45 commented 4 years ago

Progress: Checked in with @jbubar in regards to progress and began working on including the github API to display github photos. Blocks: Working on how to implement my code with the existing code on Josh's branch. Availability: Limited, due to illness. ETA: Ongoing

ExperimentsInHonesty commented 4 years ago

We identified that the data that @efrenmarin45 needs is already in the repository at the following location _data/github-data.json. its just a mater of finding the github handle name and then from there moving up to the id.

ExperimentsInHonesty commented 4 years ago

@jbubar I setup the following email address hflasheetsapi@gmail.com and put the password in 1password. Please accept the invitation and then I can add you to the vault so you can access.

jbubar commented 4 years ago

Progress: Gained an understanding of github actions, and tested it out on my own project. blocks: did not figure out onepassword. signed up but not sure how to get the password for the hflasheetsapi@gmail.com ETA: probably by the end of wednesday (09/16/20) Availability: today, and wednesday

alexandrastubbs commented 4 years ago

@jbubar any updates on this?

jbubar commented 4 years ago

Progress: little progress. Still testing out github actions. I got the curl command working, but i have not figured out how to generate a new file with github actions. I generated the API key from the google account that bonnie gave me and got that working too. Blocks: I do not understand github actions yet ETA: Next week, by next sundays meeting Availability: after 6pm pst every day

jbubar commented 4 years ago

Its working! I got the page working with github actions and github secrets. I am ready to push the MVP.

Things that still need to be completed with future commits:

screencapture-localhost-4000-wins-2020-09-20-13_50_39

alexandrastubbs commented 4 years ago

@jbubar can you provide an update on the issue and any changes to the mobile? Please share screenshots!

ExperimentsInHonesty commented 4 years ago

@jbubar Please work on the More link next

ExperimentsInHonesty commented 4 years ago

@jbubar let's have a conversation about adding in a column for approval.

alexandrastubbs commented 4 years ago

We need to have a column with the title display added to the spreadsheet and if the column does not have the value 'true' in it, then we do not display. @jbubar @efrenmarin45

jbubar commented 4 years ago

@alex, @ExperimentsInHonesty I can that out, I can add a column with a value of true or false. Thanks for clarifying alex. I am working on the more link this week. I will share my progress tomorrow

jbubar commented 4 years ago

@alexandrastubbs @ExperimentsInHonesty do you want to give the winner (person who fills out the form) the choice to display it or not? or is it more for us to monitor it?

jbubar commented 4 years ago

Progress: I added a column on the google sheet that allows for approval to display cards on the wins page. Screen Shot 2020-10-03 at 10 24 01 AM I also added the logic to exclude pages that do not have "display" in column N.

Blocks: I had some conflicts with git, so I need to work that out before I create a pull request for this. I may just start a new fork and do it over again.

ETA: I will finish this display approval before the meeting tomorrow. And I will add the see more by next week.

availibility: 1.5 hours today, and from 6 - 8 pm on weekdays

alexandrastubbs commented 4 years ago

@jbubar not sure if you discussed in the meeting today, but this is more for us to monitor. By filling out the form, it is sort of assumed that they are opting in to being featured on the page.

alexandrastubbs commented 4 years ago

@jbubar please provide progress?

  1. Progress
  2. Blocks
  3. Availability
  4. ETA
efrenmarin45 commented 4 years ago

Progress: Met with Kian a while back to discuss how I would go about fleshing out the Github avatar url.
Blocks: I have been away taking care of my Dad and have limited time to work on this. Availability: Friday - Sunday ETA: Ongoing

alexandrastubbs commented 4 years ago

@jbubar please provide an update!

  1. Progress
  2. Blocks
  3. Availability
  4. ETA
alexandrastubbs commented 4 years ago

Google form: https://docs.google.com/forms/d/1ZhyJ98nrscV3c09RT_E_sJXrHkKcUt6_a1qoChH5pQ4/edit

Need to limit wins to a single win in order to make sure the styling is consistent and to limit clutter on card. @ExperimentsInHonesty can you confirm you are aligned? This would be for the what do you want to celebrate question in google form.

alexandrastubbs commented 3 years ago

@jbubar has limited time so we are handing off remaining work to @ruben1s . @jbubar will provide an update on what he has completed and what is left to do.

jbubar commented 3 years ago

@ruben1s for the MVP we need to create the 'see more' functionality, and add github avatar photos.

see more:

Different for mobile(expands downwards) and desktop(modal popup) as you can see in the figma. Raudel was able to build out the modal functionality for desktop view, here is his branch.

github photos:

@efrenmarin45 is working on the github avatar photos.

Thanks for taking this on Ruben, happy to clarify anything else.

ruben1s commented 3 years ago

Update: Haven't made any significant progress on the mobile layout. I need to get with devs and @jbubar to go over his logic/code.

ExperimentsInHonesty commented 3 years ago

@efrenmarin45 @rblaz001 - heard you all are going to bring this across the finishline. Please provide an update

  1. Progress
  2. Blockers
  3. Availability
  4. ETA
jbubar commented 3 years ago

Changed the data type of the card data for readability and to make it easier to change, including Raudel's additions Screen Shot 2020-11-03 at 11 38 50 AM Screen Shot 2020-11-03 at 11 39 25 AM

And put the "see more" inside the text. screencapture-localhost-4000-wins-2020-11-03-11_35_11