Closed daniellex0 closed 3 years ago
A little update:
I took a look at the classes and scss file for almost all pages (minus 'dashboard' since it looks like that has a different layout). Pages I took a dive into are: About, Events, Wins, Communities of Practice, Credits, Getting Started, Join Us, Program Areas, Project Team Meetings, Sitemap, and Toolkit. Among these, there are a handful of different reasons why the headers are not sitting correctly on their associated page.
This is a good opportunity to fix continuity across the site pages, but it will take a little refactoring.
Observations:
class="header-container"
, but instead class="header-container--yourPageName"
. I think it would be a good idea to move forward with the margin change on .header-container being changed to 61px so it's the same along all pages, and adjust the unchanged pages accordingly to close this issue.
Next Steps:
I'll have a pull request ready to close this in the next few days.
Overview
We need to fix the ".header-container" class because for some reason it is no longer providing the correct margin to cover the top nav bar, and most of our headings are now too close to the top nav bar as a result
Action Items
".header-container" class margin (orange section below) used to cover the entire top nav bar- now it only covers half.
This needs to be fixed because most of our headers using the standard header class are now too close to the top nav bar: