Closed averdin2 closed 2 years ago
ignore: ["consecutive-duplicates-with-different-values"]
to .stylelintrc.json filePlease add update
margin-top: 52px
but then there was another line lower margin: 0
which overwrites that style. I changed line 5 to say margin: 52px 0 0 0;
with the intended changes included. In the pictures below, I show what it looked like originally vs my changes. I personally don't know what the website should look like, should there not be a margin top of 52px? I assumed that there should be and added it in (I personally think the page looks better without).
margin-bottom: 0
was being overwritten by a line lower margin: 45px
. I changed the code so that there is only margin: 45px
on line 257. I looked at the website with the margin-bottom added correctly, but I ultimately decided that having a margin of 45px on this class looks better. Having a margin-bottom of 45px instead of 0 didn't change the position of the cards either. See the below screenshots for a visual of both.
text-align: center
and another text-align: left
two lines lower. Since the website was using the text-align: left
styles, I decided to change line 327 to text-align: left
and removed the other line. See both the text-align center and left below.
flex-basis: 100%
. This caused linting issues with a line underneath it that said flex: 1
. The flex basis line wasn't adding any styles, and the flex: 1
line makes the page look a lot better (this is what I kept). See the screenshots below for with only flex basis set, none set, and flex: 1 set.
text-align: left
would have been the style attribute displayed, so I changed each line to be text-align: left
and removed the duplicate text-align attribute. I believe that some of these styles are not even being used in the site, which is why I don't have images for the changes, but the code would be using text-align: left
.
Progress: I am pretty much done with the linting fixes. I need to pull current code and recheck before making a PR. I haven't decided if this should be made a PR before the acutal GitHub action gets implmented yet. I also was hesitent to make linting fixes to wins page since there is wins feature branch. May want to make a similar issue for the wins feature branch. Blockers: None, just working slowly on this issue. Availability: I attend most meetings and am fairly available on slack. Also available most evenings, scheduled ahead of time. ETA: Not sure. Still deciding if I should wait until the acutal GitHub action is implemented first.
@averdin2
Please add update using this template (even if you have a pull request)
If you need help, be sure to either: 1) ask for help at a Tuesday or Sunday meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, August 10, 2021 at 12:10 AM.
Note: This comment was created as part of a GitHub Action during its trial phase. If you find this GitHub Action to be disruptive/unhelpful, or if you believe there might be a bug, please leave a comment on this issue. All feedback will be used to further improve it. Thank you for your time.
@averdin2
Please add update using this template (even if you have a pull request)
If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, August 17, 2021 at 12:02 AM PST.
@averdin2
Please add update using this template (even if you have a pull request)
If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, August 24, 2021 at 12:03 AM PST.
Progress: Just waiting on issue #1441 to be merged to make a PR for this.
@averdin2
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, September 7, 2021 at 12:02 AM PST.
@averdin2
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, September 14, 2021 at 12:02 AM PST.
@averdin2
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, September 21, 2021 at 12:02 AM PST.
@averdin2
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, September 28, 2021 at 12:02 AM PST.
@averdin2
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, October 5, 2021 at 12:02 AM PST.
@averdin2
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, October 12, 2021 at 12:02 AM PST.
Hi @averdin2, I will DM you on slack to find out more info on how you want to move forward on this. Thanks :)
@averdin2, @macho-catt
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, October 19, 2021 at 12:03 AM PST.
@averdin2, @macho-catt
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, October 26, 2021 at 12:03 AM PST.
@averdin2, @macho-catt
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, November 2, 2021 at 12:03 AM PST.
@averdin2, @macho-catt
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Monday, November 8, 2021 at 11:03 PM PST.
Will reach out again to @averdin2
PR is opened and is being reviewed
@averdin2, @macho-catt
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Monday, November 22, 2021 at 11:19 PM PST.
@averdin2, @macho-catt
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Monday, November 29, 2021 at 11:19 PM PST.
Will reach out again to @averdin2 to update the PR
Overview
I recently made a GitHub action for Linting our CSS, see issue #1441. I decided that this GitHub action would not lint the entire codebase, only code that is committed on the pull request. However, there are still linting issues throughout the entire code base. We need to go through and clean up that code using the linter showing all the issues.
Action Items
VALIDATE_ALL_CODEBASE: true
, and commit the changes to run the lining test on the entire codebase.VALIDATE_ALL_CODEBASE: false
.