hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
324 stars 760 forks source link

Google Apps Script: Migrate Wins Data - Delete AF file #2148

Open Aveline-art opened 3 years ago

Aveline-art commented 3 years ago

Dependency

Overview

As a developer, to turn the wins card into a reusable component, we must first be able to generate a wins-data.json file of a more specific format. This issue is part of a series that aims to migrate us to the more specific format.

Action Items

Resources/Instructions

wins-page

Currently we have two json files for wins: _wins-data.json and wins-data.json. The former will henceforth be called KVF (for key-value file) and AF (for array file). AF is generated daily from a script on google while KVF appears to be an older, dysfunc version. The format in the KVF version, however, is much friendlier to formatting in liquid syntax. Therefore, we need to incrementally port our codebase to use the KVF version of the data and remove the AF version we currently use. This will be done in multiple steps:

  1. Have the apps script generate both AF and KVF version.
  2. Migrate all uses of AF to KVF.
  3. Have the apps script stop generating the AF version.
  4. Delete the AF version from our repo since it is now unused.

For this issue, we are doing step 4.

github-actions[bot] commented 1 year ago

Hi @steven-positive-tran, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

steven-positive-tran commented 1 year ago

Availability: "How much time will you have this week to work on this issue?"

ETA: "When do you expect this issue to be completed?"

jdingeman commented 1 year ago

Moved this back to the Ice Box since its dependency has not been satisfied.

github-actions[bot] commented 1 year ago

Hi @Abdessittir, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

AHP15 commented 1 year ago

i. Availability: after 2 days ii. Next Monday

roslynwythe commented 1 year ago

Hi @Abdessittir this issue is in the "Ice Box" column of the Project Board and is not ready for assignment. Please select issue only from the Prioritized Backlog column.

AHP15 commented 1 year ago

Hi @roslynwythe, thanks for letting me know, but I didn't find any second issue in the Prioritized Backlog column, should I wait until one is added?

roslynwythe commented 1 year ago

Hi @roslynwythe, thanks for letting me know, but I didn't find any second issue in the Prioritized Backlog column, should I wait until one is added?

Hi @Abdessittir - instead of a second good issue, please take another first good issue. Thanks