search

hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
292 stars 707 forks source link

Add-update-label-to-issues-weekly workflow failed from Feb 17 - Mar 8, 2022 #2932

Closed SAUMILDHANKAR closed 4 months ago

SAUMILDHANKAR commented 2 years ago

Overview

As a developer, I would like all our workflows to be error-free. For this issue, we will identify why the Add-update-label-to-issues-weekly workflow failed from Feb 17 - Mar 8, 2022, and fix the error if required.

Action Items

Resources/Instructions

github-actions[bot] commented 2 years ago

Hi @SAUMILDHANKAR.

Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

github-actions[bot] commented 1 year ago

Hi @AsherEngelberg, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] commented 1 year ago

Hi @AsherEngelberg, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] commented 1 year ago

@AsherEngelberg

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, July 26, 2022 at 12:20 AM PST.

github-actions[bot] commented 1 year ago

@AsherEngelberg

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 2, 2022 at 12:20 AM PST.

github-actions[bot] commented 1 year ago

@AsherEngelberg

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 9, 2022 at 12:20 AM PST.

github-actions[bot] commented 1 year ago

@AsherEngelberg

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 16, 2022 at 12:21 AM PST.

github-actions[bot] commented 1 year ago

@AsherEngelberg

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 23, 2022 at 12:25 AM PST.

github-actions[bot] commented 1 year ago

@AsherEngelberg

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 30, 2022 at 12:27 AM PST.

github-actions[bot] commented 1 year ago

@AsherEngelberg

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, September 6, 2022 at 12:28 AM PST.

kathrynsilvaconway commented 1 year ago

I am returning this issue to the prioritized backlog because this dev has left HfLA.

github-actions[bot] commented 1 year ago

Hi @MarkWiltberger, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/01/2023 Wed 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/02/2023 Thu 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/04/2023 Sat 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Progress: "What is the current status of your project? What have you completed and what is left to do?" I have inspected the files in question and the logs for the failed workflows. Failure was due to a null object. I have set up a test repository and gotten up to speed on how GitHub Actions work. I have looked at the hackforla document "How to test GitHub Actions" What is left to do: Choose a testing methodology to see if the error can be reproduced. Decide on a course of action for possibly fixing the error if necessary. Blockers: "Difficulties or errors encountered.": None Availability: "How much time will you have this week to work on this issue?" Daily 10am-6pm ET (7am - 3pm PT) ETA: "When do you expect this issue to be completed?" 03/06/2023 Mon 6pm ET (3pm PT) Pictures (optional): "Add any pictures of the visual changes made to the site so far." None.

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/07/2023 Tue 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/08/2023 Wed 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/10/2023 Fri 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/11/2023 Sat 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/12/2023 Sun 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Progress: "What is the current status of your project? What have you completed and what is left to do?" I have identified a condition in which there may be a null object returned by the API. I identified the condition by inspecting the objects from test issues created in my test repository returned by the API. What is left to do: Set up a test procedure, document the testing procedure, and determine whether there is an error that needs to be fixed. Blockers: "Difficulties or errors encountered.": None Availability: "How much time will you have this week to work on this issue?" Daily 10am-6pm ET (7am - 3pm PT) ETA: "When do you expect this issue to be completed?" 03/13/2023 Mon 6pm ET (3pm PT) Pictures (optional): "Add any pictures of the visual changes made to the site so far." None.

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/15/2023 Wed 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/17/2023 Fri 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/19/2023 Sun 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Progress: Working on test procedures to reproduce the error, test the error, and fix the code. Need to document the procedures and fix the error, if necessary. Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/20/2023 Mon 6pm ET (3pm PT) Pictures (optional): None.

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/21/2023 Tue 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/23/2023 Thu 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/27/2023 Mon 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 03/29/2023 Wed 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 04/01/2023 Sat 6pm ET (3pm PT)

MarkWiltberger commented 1 year ago

Progress: Although the log for the dates of the errors no longer exists, there is a reference to an error being generated for a method on a null property in the file find-linked-issue.js I have set up the jest testing package for node.js on my local laptop dev environment. I have reproduced the error in a simple case by passing a null property to find-linked-issue.js. I have set up a test repository in my remote GitHub account to generate test issues. I have written code that generates test issue objects. The next step is to write a test which passes these issue objects to find-linked-issue.js to check for pass or fail of real issues and issue conditions. Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 04/12/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

MarkWiltberger commented 1 year ago

Progress: At the moment, the issue is difficult to test in the current state of the code because of the tight coupling, lack of separation of concerns, and general complexity. While it is possible to test find-linked-issue.js with a simple case, it is difficult to test the code which calls it, add-label.js. Thus it is difficult to test find-linked-issue.js with real GitHub Issue data, and it is difficult to test add-label.js to make sure it was not broken. I created a Static Call Graph of add-label.js to see the structure of the function calls, in order to analyze how the functions could be refactored so that they may be tested more easily. The diagram is embedded below under Pictures. The next action is to finish analysis of the diagram and the code to determine future action item options. In addition, creating tests for calling the GitHub Action API for the Issue object is another possible action item. Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 04/19/2023 Wed 6pm ET (3pm PT) Pictures (optional):

Figjam-hackforla-githubaction-add-label-static-call-graph 2023 04 16 mtw
MarkWiltberger commented 1 year ago

Progress: I have looked into how to use jest testing package to test private functions in node.js. Next Steps are to look further into how to conduct unit tests of functions of add-label.js and find-linked-issue.js. Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 04/26/2023 Wed 6pm ET (3pm PT) Pictures (optional):

MarkWiltberger commented 1 year ago

Progress: I have looked into how to test private functions in Node.js/Javascript. There are several techniques, each of which is not perfect. The most straightforward method, which avoids the installation of additional node modules or plugins and additional testing code syntax to learn, is to export the private functions in the code. The private functions are exported conditionally on an environmental variable so they will only be exported in a testing environment. Additionally, the exported object of private functions will be named with a convention that indicates to a developer that it is a private function, and not to be imported by another node module.

Next Steps are to write unit tests for the private function in the module and try the tests to see if the technique works. Additionally, the GitHub action workflow must be tested to make sure that the workflow still works correctly in the production environment (the GitHub actions project environment).

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 05/03/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

MarkWiltberger commented 1 year ago

Progress: I am in the midst of writing tests for the script functions

Next Steps: Finish writing the tests and try them out.

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 05/10/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

MarkWiltberger commented 1 year ago

Progress: I am in the midst of writing tests for the script functions. I was able to successfully export the private functions and test them.

Next Steps: Finish writing the tests and try them out.

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 05/17/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

MarkWiltberger commented 1 year ago

Progress: I have been writing tests for the script functions.

Next Steps: Continue writing test scripts.

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 05/24/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

MarkWiltberger commented 1 year ago

Progress: No progress/time allotted this week on writing test scripts. Did research on testing/refactoring best practices.

Next Steps: Continue writing test scripts.

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 05/31/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

MarkWiltberger commented 12 months ago

Progress: No progress.

Next Steps: Write test scripts.

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 06/07/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

MarkWiltberger commented 11 months ago

Progress: Researched e2e tests in github context on local machine.

Next Steps: Write test scripts.

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 06/14/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

MarkWiltberger commented 11 months ago

Progress: Updated the team and project leads on the issue at the Sunday DEV/All Teams meeting last Sunday, June 11.

Worked on writing integrated test script.

Next Steps: Write test scripts.

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 06/21/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

MarkWiltberger commented 11 months ago

Progress: Worked on writing test scripts.

Next Steps: Continue working on writing test scripts.

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 06/28/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

MarkWiltberger commented 11 months ago

Progress: Looked at github and context objects in action-script but otherwise did not have time to make much progress.

Next Steps: Write test scripts that are started via Github Actions using Act/Nektos or via node.js. I do not have much time over the next week to work on this so I am setting the ETA for 10 days out.

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 07/12/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

github-actions[bot] commented 10 months ago

@MarkWiltberger

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, July 11, 2023 at 12:18 AM PST.

MarkWiltberger commented 10 months ago

Progress: I have been traveling and unable to make progress on this issue the past week.

Next Steps: Write test scripts that are started via Github Actions using Act/Nektos or via node.js.

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 07/26/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

github-actions[bot] commented 10 months ago

@MarkWiltberger

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, July 25, 2023 at 12:15 AM PST.

MarkWiltberger commented 10 months ago

Progress: I have been on vacation and unable to make progress on this issue the past week.

Next Steps: Write test scripts that are started via Github Actions using Act/Nektos or via node.js.

Blockers: None. Availability: Daily 10am-6pm ET (7am - 3pm PT) ETA: 08/09/2023 Wed 6pm ET (3pm PT) Pictures (optional): None.

github-actions[bot] commented 9 months ago

@MarkWiltberger

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, August 8, 2023 at 12:06 AM PST.

github-actions[bot] commented 9 months ago

@MarkWiltberger

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, August 15, 2023 at 12:05 AM PST.