hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
294 stars 722 forks source link

Redesign Citizen's Engagement's SDG sizes and related padding #3117

Closed phuonguvan closed 1 year ago

phuonguvan commented 2 years ago

Overview

We need to make sure that all text on the site is minimum 16pt, including text on the SDG icons, which will also require padding changes to accommodate.

Details

We need to make sure that the Website and the Figma design match for the Citizen Engagement page, so that the current website has the most up-to-date design decisions and that the Figma file is ready for future iterations.

Action Items

Resources/Instructions

Details

Website

SDG text box width: 280 SDG image is 120x120

Website Screenshot ![image](https://user-images.githubusercontent.com/100561599/167723661-cd3bb936-bc97-491c-b5e1-adf25a44ec49.png) ![unknown (1)](https://user-images.githubusercontent.com/100561599/167619259-6605f408-ffa4-49ed-b105-2956e581d363.png)

Figma

SDG text box width: 318 SDG image is 88x88

Figma ![image](https://user-images.githubusercontent.com/100561599/167724052-82743bea-7f8f-4faf-aef5-4abb0ba4f158.png) ![image](https://user-images.githubusercontent.com/100561599/167723983-19f5c787-867a-4fa5-b037-ecca71633f70.png)
github-actions[bot] commented 2 years ago

Hi @phuonguvan.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing: Size, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

github-actions[bot] commented 2 years ago

@EmilyTat

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, May 31, 2022 at 12:19 AM PST.

EmilyTat commented 2 years ago

Availability for this week: 6 hrs My estimated ETA for completing this issue: EOD 06/10/22

EmilyTat commented 2 years ago

Provide Update

  1. Progress - I have completed steps 1 & 2, reviewing screenshots and making a working copy of the 16pt version with a blue line around it in Figma File.
  2. Blockers - All text on website and Figma file is 16 pt - unsure what needs changing - is it the text on the actual image? Unsure how to edit this in Figma.
  3. Availability - 6 hrs
  4. ETA - EOD 06/10/22
EmilyTat commented 2 years ago

Want to discuss and work together on this in next Design Team Meeting, thank you!

github-actions[bot] commented 1 year ago

Hi @gold-o, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] commented 1 year ago

Hi @gold-o, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] commented 1 year ago

@gold-o

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, July 5, 2022 at 12:19 AM PST.

github-actions[bot] commented 1 year ago

@gold-o

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, July 12, 2022 at 12:20 AM PST.

gold-o commented 1 year ago

Progress: I have redesigned the SDG section and padding for the citizen engagement cards on the website page. I still have to redesign the SDG section for the mobile page, but I have a few questions. Blockers: N/A Availability: 4-5 hours ETA: By the end of this week (by 07/23) Pictures (optional): "Add any pictures of the visual changes made to the site so far." Screen Shot 2022-07-17 at 3 15 41 PM

github-actions[bot] commented 1 year ago

@gold-o

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, July 26, 2022 at 12:20 AM PST.

github-actions[bot] commented 1 year ago

@gold-o

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 2, 2022 at 12:20 AM PST.

github-actions[bot] commented 1 year ago

@gold-o

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 9, 2022 at 12:20 AM PST.

github-actions[bot] commented 1 year ago

@gold-o

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 16, 2022 at 12:21 AM PST.

github-actions[bot] commented 1 year ago

@gold-o

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 23, 2022 at 12:25 AM PST.

github-actions[bot] commented 1 year ago

@gold-o

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 30, 2022 at 12:27 AM PST.

github-actions[bot] commented 1 year ago

@gold-o

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, September 6, 2022 at 12:28 AM PST.

gold-o commented 1 year ago

Progress: I have completed the desktop design for the issue Blockers: For the mobile version, when the font is changed to 16pt and the image is resized, it changes the design. It would be good to explore the best way we can design the mobile version of this page with the new SDG sizing. Availability: N/A ETA: The issue is completed

Screen Shot 2022-09-12 at 3 35 58 PM

gold-o commented 1 year ago

The issue is completed. For the mobile version, developers will use the original SDG image with the 90 pixels sizing.

ExperimentsInHonesty commented 1 year ago

Hi Dev leads.

The latest version is on this figma frame labeled final version

If you are unclear what needs to be done, please bring this to the sunday or monday meeting.

JessicaLucindaCheng commented 1 year ago

Hi Dev leads.

The latest version is on this figma frame labeled final version

If you are unclear what needs to be done, please bring this to the sunday or monday meeting.

JessicaLucindaCheng commented 1 year ago

@ExperimentsInHonesty I just want to confirm a couple of notes:

JessicaLucindaCheng commented 1 year ago
JessicaLucindaCheng commented 1 year ago

@ExperimentsInHonesty I know the mobile design is staying the same. However, the current Citizen Engagement webpage SDG image size, SDG paragraph text size, and the SDG header text size do not match the Current Page Figma design.

Ans:

JessicaLucindaCheng commented 1 year ago

Hi Dev leads.

The latest version is on this figma frame labeled final version

If you are unclear what needs to be done, please bring this to the sunday or monday meeting.

...

  • From 2023-01-16 Dev/PM meeting, Bonnie said the mobile view of the webpage is fine as is. The mobile design should match the page. So, write an ER issue so that the mobile design is updated to match the page.