Closed kathrynsilvaconway closed 1 year ago
Hi @kathrynsilvaconway.
Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing: Role, Feature
NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.
To add a label, take a look at Github's documentation here.
Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.
After the proper labels are added, the merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.
Additional Resources:
@kathrynsilvaconway you mention that they should
After you verify that the contents has been copied correctly, you can delete the original _project-filter.scss file.
But there is no mention that they should check to see if the pages that use it still work.... and I am left wondering if there are other steps they have to do to make sure the files that use the code know where to find it.
--
Also, when you use the issue making template, please delete the no dependency part or anything else that is unnecessary to the issue. We do this to reduce cognitive load.
@kathrynsilvaconway left you a note above, and it looks like you did not address what I mentioned, but changed the labels back to ready for milestone. Please address https://github.com/hackforla/website/issues/3256#issuecomment-1253935127
Changes requested have been made.
Hi @DmitriiTsy, thank you for taking up this issue! Hfla appreciates you :)
Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)
You're awesome!
P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)
Hi guys, hi world!
Availability: 2 hours ETA: 2 hours
Hello Team,
Added a couple of items to clarify the issue:
dropdown_filters.scss
to _dropdown_filters.scss
to match naming conventionmain.scss
and delete the import statement, otherwise this will break the pageAvailability: 6 hours ETA: 2 hours
@DmitriiTsy Turns out we are trying to make sure that the filters are navigable by keyboard, not sure if the work you are doing on this issue needs to take that into account, but I thought I would drop you the resources Z has gathered
Thank you for these resources. It's amazing
P.S. I'm on vacation till 11/28/2022
As per the discussion - Dmitrii found a job, and doesn't wish to contribute for now. So, I am un-assigning and moving this issue back to prioritized backlog
so that other dev can work on it.
Hi @wendybarrios, thank you for taking up this issue! Hfla appreciates you :)
Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)
You're awesome!
P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)
i. Availability: Monday, Tuesday, Thursday : 8:00am - 12:30pm and 6:00 pm - 7:30pm ii. ETA: Tuesday, 1/17
Blockers: School/Work Availability: Evenings after 6:00pm ETA: 1/27
Overview
Currently, the dropdown filters menus on the projects page and the toolkit page use different SCSS classes, which creates visual inconsistency for the user and also makes it hard for future developers to apply changes correctly. We need to create an SCSS file the will contain all the classes necessary to build our filter menus and store it in the elements folder for future use.
Action Items
Note to Merge Team/Tech Leads:
Resources/Instructions
Here is the _project-filter.scss file: https://github.com/hackforla/website/blob/gh-pages/_sass/components/_project-filter.scss