Closed JessicaLucindaCheng closed 3 months ago
Hi @JessicaLucindaCheng.
Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.
Additional Resources:
The notes below are copied from https://github.com/hackforla/website/issues/3031#issuecomment-1156971748
Notes from June 15 meeting with Josie from GitHub
Migration feature
to be rolled out soon (maybe in next few days) would enable all members with write-access to be able to migrate the project to beta version.Notes below copied from https://github.com/hackforla/website/issues/3031#issuecomment-1153077541.
Notes on how to create the project at the org level, associate the project to the repo and then access the project at the repo level
Figure out the answers to these questions
1) For future reference, I have taken a screenshot of the default "Who has access" and "Manage access" settings of the beta project board when we did the initial test migration:
2) After taking the above screenshot, I changed the following in the "Who has access" and "Manage access" settings, so that non-leadership people do not see the beta project board since we are not currently using it yet and it was confusing people seeing two project boards:
Write
to No access
website
and website-write
teams.3) Read the info in the blue box about Migrating your project to Projects (beta): https://docs.github.com/en/issues/trying-out-the-new-projects-experience/migrating-your-project . Some highlights:
It seems like when we migrated, it brought the automation rules at the time. When we tested this by changing what happens to reopened PRs (no longer added to in progress, instead added to PR needs review) it did not update the automations listed here: https://github.com/orgs/hackforla/projects/15/workflows/1671601 Although it looks like not all of the automations got migrated, because reopening an issue not listed there.
Copying notes related to the board migration from the Dev/PM agenda on 2022-09-19 (https://github.com/hackforla/website/issues/2607#issuecomment-1246112979) to here:
From Slack on 2022-09-24, copying Bonnie's Slack post on why we should hold off on migrating to the beta project board to here:
The website team had a 2 hour meeting with GitHub and here is why we want everyone to hold off
- When you make the board it will have to have your project name, unlike the current boards, because they will all be in one place, so having multiple project boards be called "project board" or project management" will make it impossible to know which one is yours. a. Please add your project initials to your project board now. (e.g., Food oasis project board would be called FOLA: Project Management)
- Currently, they will be changing this hopefully soon, when you go to one of the new boards, you leave the menu for your project repo. So moving from board to issues to wiki tabs is impossible. You have to navigate back to your repo and the menu of how to do that has changed to a new placement that is not intuitive.
- Many projects have links in their wiki to the current boards. Each project will need to write up a migration plan for what links will need to be changed to make sure there are not out of date links on their project
- Many projects have cards on their project board. These will be automatically converted to draft issues and they don't work the same way as cards, so that information will need to be part of the projects migration plan. Probably these links will need to be moved to the wiki.
Additional post by Bonnie:
See also this wiki page with details https://github.com/hackforla/admin/wiki/GitHub:-Project-Boards
This issue needs to be re written or replaced
The following tests need to be performed by someone who has a classic project board on their forked copy of the repo
Do we have to revise the GHA that adds it, so it goes to both?
https://github.com/hackforla/website/blob/gh-pages/.github/workflows/move-closed-issues.yaml https://github.com/hackforla/website/blob/gh-pages/github-actions/move-closed-issues/sort-closed-issues.js
Testing in my repo:
Does a github action that moves an issue from QA on close to the done column (designed for the old board to move an issue to another column) still work on the new board
Does the GitHub Action need to be changed for the new project board, or does it work there automatically. Does it still work on the old board.
https://github.com/hackforla/website/blob/gh-pages/.github/workflows/move-closed-issues.yaml https://github.com/hackforla/website/blob/gh-pages/github-actions/move-closed-issues/sort-closed-issues.js
@ExperimentsInHonesty
3 issues opened, and 3 corresponding PRs generated before Migration:
role: back end/devOps
, role: front end
,1 feature: refactor GHAs
After migration, I reviewed, approved, merged all 3 PRs:
pull-request-trigger.yml
at step "Gather-Merged-PRs- had failure with "alex-page" automation: could not find 'Project Board' or column name, so automation to remove the PR did not work.move-closed-issue.yml
failed at the step "run-alex-page-automation": could not find "Project Board" or "QA" columnall three issues sent to "QA" column after PR was merged and issue closed
Then I reopened the "Project Board(classic)" and also reopened the 3 issues, placed each issue in "In Progress" for both boards, then closed the issues again:
move-closed-issues.yml
ran without errors, role: back end/devOps
: was sorted to: "Done" on (classic), --> However, went to "QA" on new board role: front end
sorted to "QA" on both boardsfeature: refactor GHAs
sorted to "QA" both boardsOpened a new issue with both boards active. The new issue only opened in "Project Board (classic)"
Re-closed the classic board and opened a new issue.
issue-trigger.yml
fails at "alex-page"So far, the automations that involve moving issues to specific columns are the ones not working correctly and/or are failing. These include automations that use alex-page/github-project-automation-plus@v0.9.0
(three workflows):
move-closed-issues.yml
,
pull-request-trigger.yml
, and
issue-trigger.yml
Also includes schedule-fri-0700.yml
, which although it runs without error, it does not actually do anything. It is supposed to look for issues in the column matching the "IN_PROGRESS_COLUMN_ID" but it does not look for or find the column, and then apparently finishes without doing anything.
@ExperimentsInHonesty
Updates: in the new Project Board / Project Board Beta's "Default workflows", there are options for adding new issues and new PRs to the Board- This makes much of the refactoring easier.
Created issues:
This note from the 'Sunset Notice' seems to imply that GitHub is retiring the REST APIs in November- which is reason for the second issue (6994). Even if this isn't the case, it might still be a good idea to start planning to convert to GraphQL anyway...
Issue Workflow |
Step | Problem | If It Isn't Fixed |
---|---|---|---|
#6996 issue-trigger.yml |
"Add-Issue-To-Project-Board" | OK if code removed and we use PBB "Default workflows" #6995 | n/a |
" " | "Ask-For-Preliminary-Update" | .js file references 'column' | won't post the Prelim. Update comments (option: we could revert #6811 until fixed) |
#6997 pull-request-trigger.yml |
"Move-New-PRs-To-Project-Board" | OK if code removed and we use PBB "Default workflows" #6995 | n/a |
" " | "Gather-Merged-PRs" etc. | alex-page action + 'column'Note: closed PRs, Issues can be Auto-Archived in PBB #6995 |
Merged PRs, Closed/unmerged PRs won't be removed from Project Board |
#6998 schedule-fri-0700.yml |
"Add-Update-Label-Weekly"add-label.js |
The .js file refs 'column' | Update labels eg. 2 weeks inactive ,To update! won't be added to issues |
#7039 move-closed-issues.yaml |
"move-closed-issue"sort-closed-issues.js |
alex-page action + 'column'Note: closed issues sorted to "QA" in PBB #6995 |
All closed issues will sort to 'QA' status |
[x] Submit a DRAFT PR to Remove the following workflows
[x] Submit a DRAFT PR to Revert https://github.com/hackforla/website/pull/6811
[ ] Rewrite an issue to remove the reference to columns in the workflow, so that it adds the labels in any column.
schedule-fri-0700.yml "Add-Update-Label-Weekly"add-label.js The .js file refs 'column' labels eg. 2 weeks inactive,To update!
[x] Make a new issue (put in icebox) to refactor schedule-fri-0700.yml after the migration so that it goes back to only applying to the required columns
Additional notes: We need to revise the wiki docs including:
Bonnie to review all open comments and see if this issue can be closed.
Dependency
Details
Overview
As a member of the Website Team, we need to prepare for the migration of our Project Board from "Projects (classic)" to "Projects (Beta)" so that if "Projects (classic)" is deprecated we are ready to use "Projects (Beta)" with our team. For this issue, we will figure out what needs to be done in order for us to migrate, add those as Action Items below, and complete those Action Items.
Action Items
Notes for emails from GitHub rep Josie
Features related to automations and insights in the new project beta
Those tracks of work are on hold until GA but someone from GitHub might reach out once teams at GitHub are ready to get that track of work started. Can follow up with Josie on timelines for this.Information on a bug and how to resolve it
If you’re seeing the “Migration complete” modal and you are unable to dismiss it, it is likely that you are not opted in to the feature preview for project migration. GitHub team recently put the entire feature behind a feature preview so if you are not in the feature preview, you will run into issues like this. Action: If you are using project migration and have not yet opted in to the feature preview, please do so before you continue accessing previously migrated projects.Resources/Instructions