Closed ericvennemeyer closed 2 years ago
@ericvennemeyer Nice work writing this up, Eric. I am removing the draft label, it is ready for approval.
@ExperimentsInHonesty Issue is well written and specific. Ready for milestone.
@ExperimentsInHonesty very clear and straight-forward! We can add a "good second issue" label for new members.
Maybe move the last action item: "comparing toolkit page" to an Acceptance Criteria section at the end
7kram said
@ExperimentsInHonesty very clear and straight-forward! We can add a "good second issue" label for new members. Maybe move the last action item: "comparing toolkit page" to an Acceptance Criteria section at the end
@7kram
Hi @Mattre7, thank you for taking up this issue! Hfla appreciates you :)
Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)
You're awesome!
P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)
i. Availability: Sundays and Mondays. Rest of the days I work, but can still do a little bit, especially after 9 PST. ii. Likely Tuesday 9/20 (tomorrow), at the latest, Sunday 9/25.
Overview
As a developer on the website team, SCSS code is easier to understand and maintain when it does not contain duplicate selectors. This issue is to consolidate duplicate selectors within
_toolkit.scss
.Action Items
.resource-svg-icons
appears on line 120, and again on line 225..toolkit-info-container
appears on line 126, and again on line 230..toolkit-info-container h3
appears on line 130, and again on line 231.Acceptance Criteria
Resources/Instructions
The duplicate selectors were highlighted when they failed to pass a
Lint SCSS
test for PR #3483. _toolkit.scss toolkit page CSS Specificity Rules --> "When two selectors in the same cascade layer and origin have the same specificity, proximity is important; the last selector wins."