hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
324 stars 766 forks source link

Fix the dropdown menu design for projects page #3744

Closed blulady closed 1 year ago

blulady commented 1 year ago

Dependency

Overview

During recent audits, the team realized that the drop-down menu design is not uniform. In an attempt to unify all drop-down menus the design team has redesigned the drop-down menu. This issue is to implement the new uniform design specifically on the projects page.

Action Items

Resources/Instructions

Design Systems Accessibility Resources Standardized Components Wiki specifically:

github-actions[bot] commented 1 year ago

Hi @kurikurichan, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] commented 1 year ago

@kurikurichan

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, March 6, 2023 at 11:17 PM PST.

github-actions[bot] commented 1 year ago

Hi @chrismenke45, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

chrismenke45 commented 1 year ago

Availability: Tues, Wed 8am-12pm. Thurs 12pm-6pm. ETA: 3/24

chrismenke45 commented 1 year ago

Progress: I've set up the general layout and the functionality of the filters works Blockers: I will need to learn more about keyboard accessibility to finish Availability: Mon-Fri 8am-12pm ETA: 3/24

chrismenke45 commented 1 year ago

3/24 Update: PR Created Available: 3/25 8am-12pm

ExperimentsInHonesty commented 1 year ago

@chrismenke45 Please change your pr to a draft and fix the following issue then take off the draft label

The current mockup shows the filter on the side being higher. And even without the search bar, its still to low.

Current mockup from Figma

image

Your screenshots from your dev

chrismenke45 commented 1 year ago

@ExperimentsInHonesty Will do! Thank you for looking over it so quickly!

ExperimentsInHonesty commented 1 year ago

@chrismenke45 While you are waiting for your PR to get reviewed. Can you add a write up of what files go into the filter component and any other details that a person adding the same component to another page (e.g., toolkit page) will need to know. You can leave that write up here in this issue as a comment.

chrismenke45 commented 1 year ago

How to Implement Dropdown Filters on Another Page

Files to reference