hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
323 stars 775 forks source link

Consolidate Reusable Functions in github-actions #3750

Closed jdingeman closed 10 months ago

jdingeman commented 1 year ago

Overview

Developers have noted that certain javascript functions in github-actions are being declared and defined across multiple files. We want to make these functions reusable within the codebase so they are not being defined multiple times for the same function across different files.

Action Items

Resources/Instructions

github-actions[bot] commented 1 year ago

Hi @wendybarrios, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

wendybarrios commented 1 year ago

i. Availability: [Mondays, Wednesday, Thursdays]: 8:00 am - 10 am / 5:00pm - 8:00 pm ii. ETA: 3/20

ExperimentsInHonesty commented 1 year ago

It looks like you assigned yourself to this issue but didn't move it into the in progress. I'll do that now.

github-actions[bot] commented 1 year ago

@wendybarrios

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, March 21, 2023 at 12:15 AM PST.

wendybarrios commented 1 year ago
  1. Progress: Read GHA Resources
  2. Blockers: Work
  3. Availability: 5 hours
  4. ETA: 4/2
wendybarrios commented 1 year ago

I have a blocker. I am getting this error message when I run the Add-Update-Label-to-Issues-Weekly workflow on act.js. I created a file called get-timeline.js to hold the getTimeline function to use in these files: add-label.js and preliminary-update-comment.js. I'm not sure if I am calling the function correctly in add-label.js. The message says "issueNum is not defined" but I'm not sure if I'm importing/exporting the getTimeline function correctly.

Error Message:

Screen Shot 2023-04-12 at 4 28 14 PM

Get-timeline file I created to export the getTimeline function:

Screen Shot 2023-04-12 at 4 31 50 PM

Used Require to import the function to add-label.js:

Screen Shot 2023-04-12 at 4 38 52 PM

Called the function in add-label.js:

Screen Shot 2023-04-12 at 4 35 31 PM

I'm working in the "consolidate-reusable-functions-in-github-actions-3750" branch on my forked repo. Any help is appreciated!

jdingeman commented 1 year ago

@wendybarrios have you tried doing something like this

get-Timeline.js

/*
code body
*/

export { getTimeline };

and importing it into add-label.js like this

import { getTimeline } from './utils/get-timeline.js'
/* 
code body
*/
wendybarrios commented 1 year ago

@jdingeman Yes! But when I ran the workflow, this is the message I got. For this message, I tried adding: "type": "module" to the package.json file but the file was locked.

Screen Shot 2023-04-13 at 6 39 48 PM
wendybarrios commented 1 year ago

Progress: Testing GHAs Blockers: Work Availability: 5 hours ETA: 5/7

github-actions[bot] commented 1 year ago

@wendybarrios

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, May 9, 2023 at 12:15 AM PST.

github-actions[bot] commented 1 year ago

@wendybarrios

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, May 16, 2023 at 12:16 AM PST.

github-actions[bot] commented 1 year ago

@wendybarrios

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, May 23, 2023 at 12:17 AM PST.

github-actions[bot] commented 1 year ago

@wendybarrios

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, May 30, 2023 at 12:15 AM PST.

github-actions[bot] commented 1 year ago

@wendybarrios

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, June 6, 2023 at 12:16 AM PST.

roslynwythe commented 1 year ago

Hi @wendybarrios please leave us an update using the format outlined in the comments above, or let us know if you are not able to continue working on this issue. Thank you

wendybarrios commented 1 year ago

Sorry, I'll provide an update by tomorrow!

wendybarrios commented 1 year ago

Progress: Tested getTimeline(issueNum) in add-label.js and need to test getTimeline(issueNum) in preliminary-update-comment.js Blockers: GHA Testing Availability: 5 hours ETA: 6/18

roslynwythe commented 1 year ago

Hi @wendybarrios thank you for briefing us on this issue at the Sunday meeting. Please provide an update to let us know if you will be continuing with work on this issue.

wendybarrios commented 1 year ago

Update: I unassigned myself from this issue. For the future assignee, I gathered the reusable functions I could find and their locations. I stored them in this Replit link: https://replit.com/@wendybarrios/Consolidate-Reusable-Functions-in-github-actions-3750#index.js. Feel free to edit the replit! : )

github-actions[bot] commented 1 year ago

Hi @one2code, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

one2code commented 1 year ago

ETA: 09/13/23

github-actions[bot] commented 1 year ago

@one2code

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, September 5, 2023 at 12:05 AM PST.

one2code commented 1 year ago

Progress: My computer was down for repairs, I just got it back from the shop tonight, so I haven't been able to work on the issue much since I pulled the issue. Availability: I should have 2-3 hours Sunday, and then some more time on the following Wednesday & Thursday ETA: Probably going to need another two weeks, so I expect end of month.

github-actions[bot] commented 1 year ago

@one2code

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, September 19, 2023 at 12:06 AM PST.

github-actions[bot] commented 1 year ago

@one2code

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, September 26, 2023 at 12:06 AM PST.

LRenDO commented 1 year ago

Hi @one2code! Hope you're doing well and the laptop has been working for you. Are you still working on this issue? If so, please add an update. If not, please let us know you're unable to complete the issue. If we don't hear from you soon, we will remove you from the issue. Thanks!

github-actions[bot] commented 1 year ago

@one2code

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, October 3, 2023 at 12:06 AM PST.

github-actions[bot] commented 1 year ago

@one2code

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, October 10, 2023 at 12:06 AM PST.

github-actions[bot] commented 1 year ago

@one2code

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, October 17, 2023 at 12:06 AM PST.

github-actions[bot] commented 1 year ago

@one2code

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, October 24, 2023 at 12:05 AM PST.

LRenDO commented 1 year ago

Taking @one2code off of this issue since we haven't received an update. Moving back to new issue approval for re-prioritization.

github-actions[bot] commented 11 months ago

Hi @aadilahmed, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

aadilahmed commented 11 months ago

Availability: 9am- 5pm Monday-Friday ETA: 11/28 EOD