Credits page: Add "Altered by" field

JessicaLucindaCheng commented 1 year ago

Overview

We need an "Altered by" field to show up for some credits used in the redesigned version of the homepage so that the Credits webpage gives credit to Hack for LA designers that have edited images we use on the website.

Action Items

[x] Feature Branch: You will be working off a feature branch called feature-homepage-launch. Please follow "Step 1: Create your branch" in How to work off of a feature branch wiki article.
[x] If a credit's yml information file has an altered-by entry, make the Altered by: field (along with the name of the person who altered it) show up after the Provider field for that credit on the Credits page.

Click here to see an example of where the Altered by field should show up
[x] The Altered by field should show up for the following existing credits:
- [x] Diversity, Equity, Inclusion
- [x] Social Safety Net
- [x] If the pull request to fix issue #3352 has been merged, then Civic Tech Infrastructure should have the field show up as well.
[x] The "Altered by" field should also show up for any credits added in the future with that field
[x] The "Altered by" field should not show up for any credit's yml files that either
- [x] has an altered-by field that doesn't contain any information (e.g. altered-by:)
- [x] or doesn't have an altered-by field
[x] Take screenshots of the credits with the Altered by field and place them in a new comment below.
[x] Show the screenshots/visual changes to the Credits page to our Stakeholder Rep and get the Stakeholder Rep's approval of the changes you made. (You can find who the Stakeholder Rep is on the Hackforla.org Website project's detailed information webpage.)
[x] To update your topic branch, please follow "Step 2: Update your branch with upstream changes" in How to work off of a feature branch wiki article.
[x] The pull request created from this issue should be merged into feature-homepage-launch. Please follow "Step 3: Create a pull request" in How to work off of a feature branch wiki article

Tech Lead or Merge Team

[x] After the pull request associated with this issue is approved and merged, please make sure this issue is closed. If it is not closed by the automation, leave a new comment stating what pr number fixes this issue and then close this issue as completed.

Resources/Instructions

Credits page
How to work off of a feature branch wiki page
Directory of all the yml credit information files on the feature-homepage-launch branch: _data/internal/credits
- diversity-equity-inclusion.yml
- social-safety-net.yml
You can find who the Stakeholder Rep is on the Hackforla.org Website project's detailed information webpage
This issue is tracked in epic #3130.

JessicaLucindaCheng commented 1 year ago

Issue Writing

Availability: 6 hours
ETA: Sun, January 8, 2023

JessicaLucindaCheng commented 1 year ago

@ExperimentsInHonesty Since we don't have a design of how the "Altered by" field looks and this will be on the feature-homepage-launch, is QA after this issue's pr is merged sufficient? Or do you want me to add the following Action Item so that you approve of changes before it is merged? Ans: Add Action Item to get PM approval

[ ] Take screenshots of the credits with the Altered by field and show them to the PM(s) to approve of the changes.

github-actions[bot] commented 1 year ago

Hi @Satenik-Ba, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

Satenik-Ba commented 1 year ago

Availability: 1/21/23 ETA: 1 week

ExperimentsInHonesty commented 1 year ago

@Satenik-Ba I have moved this issue to in the progress column. Please do that in future when you self assign

Satenik-Ba commented 1 year ago

screenshots of the credits with the Altered by field

Satenik-Ba commented 1 year ago

Hi @ExperimentsInHonesty! Above comment has the screenshot of the visual changes to the credits page with Altered by fields. Would you please review the changes made? Thank you!

Satenik-Ba commented 1 year ago

Update Awaiting @ExperimentsInHonesty to approve the changes to the credits page with Altered by fields before pull request.

github-actions[bot] commented 1 year ago

@Satenik-Ba

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

Progress: "What is the current status of your project? What have you completed and what is left to do?"
Blockers: "Difficulties or errors encountered."
Availability: "How much time will you have this week to work on this issue?"
ETA: "When do you expect this issue to be completed?"
Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

_{You are receiving this comment because your last comment was before Monday, February 6, 2023 at 11:17 PM PST.}

Satenik-Ba commented 1 year ago

Update Awaiting @ExperimentsInHonesty to approve the changes to the credits page with Altered by fields before pull request.

github-actions[bot] commented 1 year ago

@Satenik-Ba

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

Progress: "What is the current status of your project? What have you completed and what is left to do?"
Blockers: "Difficulties or errors encountered."
Availability: "How much time will you have this week to work on this issue?"
ETA: "When do you expect this issue to be completed?"
Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

_{You are receiving this comment because your last comment was before Monday, February 20, 2023 at 11:17 PM PST.}

ExperimentsInHonesty commented 1 year ago

@Satenik-Ba The new layout works for me. I do want to add something else, though. Let's link the Altered by name to their LinkedIn. Kristine's LinkedIn is https://www.linkedin.com/in/kristine-eudey/

Sorry for the delay. If you need me to review in the future, please put this issue in the questions and review column with a ready for product label on it. Usually these questions get resolved at the Sunday meeting. If you can't make that meeting, adding it to the questions and review column will get someone's attention. You can also reach out to the leads if you are blocked.

Satenik-Ba commented 1 year ago

Sounds good, will make the updates. Availability: 2/27 ETA: 1day

JessicaLucindaCheng commented 1 year ago

PR #4053 fixed this issue.

hackforla / website