hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
317 stars 752 forks source link

Make Diversity program area field uniform #4118

Closed JessicaLucindaCheng closed 1 year ago

JessicaLucindaCheng commented 1 year ago

Overview

We want to change the wording for Write For All's program area to Diversity, Equity & Inclusion so that it is consistent with the wording used in New Schools Today's program area and we maintain a professional looking site.

Action Items

Merge Team, Technical Lead, or Product Manager

Resources/Instructions

github-actions[bot] commented 1 year ago

Hi @Alsuang, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

Alsuang commented 1 year ago

Availability: Monday 9-12pm ETA: Monday EOD

ExperimentsInHonesty commented 1 year ago

@hackforla/website-merge After reviewing this Merge, I realized that the fix made the two DEI programs uniform, but the program area drop down is not working on the projects page https://www.hackforla.org/projects.

If you go to the projects page and try to use any of the Program Areas, they all work https://www.hackforla.org/projects/?programs=Citizen+Engagement https://www.hackforla.org/projects/?programs=Civic+Tech+Infrastructure https://www.hackforla.org/projects/?programs=Environment https://www.hackforla.org/projects/?programs=Justice https://www.hackforla.org/projects/?programs=Social+Safety+Net https://www.hackforla.org/projects/?programs=Vote+/+Representation https://www.hackforla.org/projects/?programs=Workforce+Development

Except for Diversity, Equity & Inclusion because it has an ampersand in it. https://www.hackforla.org/projects/?programs=Diversity,+Equity+&+Inclusion

Let's make a new small issue to change both pages to Diversity / Equity / Inclusion and see if that makes the drop down work. Its similar to Vote / Representation so I anticipate it will.

JessicaLucindaCheng commented 1 year ago

@ExperimentsInHonesty

t-will-gillis commented 1 year ago

@ExperimentsInHonesty @JessicaLucindaCheng
I am working on #4120 - Yes "Diversity / Equity / Inclusion" will work - I just checked.

(The previous "Diversity, Equity & Inclusion" had problems not only because of the "&" but also because of the ",". Even removing the ampersand, with the comma the dropdown was splitting into two unique program areas of "Diversity" and "Equity and Inclusion" . )

ExperimentsInHonesty commented 1 year ago

@JessicaLucindaCheng @t-will-gillis I will close this issue. I have left a note on https://github.com/hackforla/website/issues/4120#issuecomment-1479808595 to go ahead and change the Program Area to be Diversity / Equity / Inclusion