hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
325 stars 759 forks source link

SDG 11: Rename and replace image with correct color one #4225

Closed JessicaLucindaCheng closed 1 year ago

JessicaLucindaCheng commented 1 year ago

Dependency

Overview

We need to replace the Sustainable Development Goals (SDG) images in our repository so that the SDG svgs are the correct color and follow the United Nations' SDG guidelines.

Details

SDG is an acronym for the United Nations Development Programme Sustainable Development Goals.

Action Items

Merge Team, Technical Lead, or Product Manager

Resources/Instructions

JessicaLucindaCheng commented 1 year ago

@ExperimentsInHonesty I'm going to be writing multiple issues to replace the SDGs in our repo and will be using this issue as a template to write the other issues. I would like to get your approval on this issue before I start writing the other ones.

ExperimentsInHonesty commented 1 year ago

@JessicaLucindaCheng looks good to me.

JessicaLucindaCheng commented 1 year ago

Once this issue is in the New Issue Approval column, a dev lead needs to review the issue and determine if it is ready for a PM to prioritize it. If it isn't ready, a dev lead will need to edit this issue so that it is ready for a PM to prioritize it.

github-actions[bot] commented 1 year ago

Hi @StephenTheDev1001, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

StephenTheDev1001 commented 1 year ago

i. Availability: Mon-Sat 4-7pm ii. ETA: Apr 7th

StephenTheDev1001 commented 1 year ago

Update

  1. Progress: Completed all tasks under "Action Items"
  2. Blockers: sdg11.svg is not displaying on Firefox.
  3. Availability: Mon - Sat 4-7pm
  4. ETA: Apr 10th

Working on sdg11-replace-img-4225 branch on my fork. @drakenguyen4000 describes the problem well HERE with images

StephenTheDev1001 commented 1 year ago

I was told at the meeting that my changes are correct and it will be merged soon.