Design System: Recommendations for Page Card CSS/HTML Standard

jdingeman commented 1 year ago

Dependency

[x] https://github.com/hackforla/website/issues/2061
[ ] Design system for Internship

Overview

We need to document recommendations for the .page-card classes so that we can then standardize and implement them for the HfLA Website.

Action Items

In issue https://github.com/hackforla/website/issues/2061, devs created a new spreadsheet noting all instances of a .*-card class and created a write-up with research on accessibility and standard practices. As the developer assigned to this issue, you will:
[x] Go through all of the instances in the spreadsheet of the .*-card classes in the HfLA repo
- [ ] Review each instance to see how it was coded, and compare it against the standards written in the write-up.
- [x] Write any "relevant methods" pertaining to accessibility and industry standard (i.e. do they use empty alt texts, are they WCAG 2.1 compliant, can they be tab-focused, etc.)
- [ ] If a class implements something that is "off" or otherwise non-standard and can be standardized, write specific recommendations on what we can do to make the class more compliant, accessible, etc.
[ ] For each instance, write the in the "Impact" column what the ramifications are for changing/refactoring any instance of the .*page-card if it needs to be changed.

Merge Team

[ ] Release dependency on https://github.com/hackforla/website/issues/2226

Resources/Instructions

/* Current default for page-card*/
.page-card {
    border-radius: 20px;
    overflow: hidden;
    width: 100%;
  }

WCAG 2.1
Design System: Audit Page Card write-up
First part of the Design System Audit for Page Card CSS/HTML Standard: https://github.com/hackforla/website/issues/2061

github-actions[bot] commented 1 year ago

Hi @KazushiR, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

KazushiR commented 1 year ago

Availability: Mon-Frid ETA: 05/01/2023 11:59pm

KazushiR commented 1 year ago

Update: I have been a bit busy so I haven't had anytime to work on this. I will make time this week to start on this issue.

KazushiR commented 1 year ago

@hackforla/project-leads It seems as though some of the files do not have any hyperlink. Should I ignore these and look at the ones with a hyperlink?

jdingeman commented 1 year ago

@KazushiR - if it has the relative path, you should still be able to see it unless the file has been deleted.

KazushiR commented 1 year ago

@KazushiR - if it has the relative path, you should still be able to see it unless the file has been deleted.

Got it. Thank you for the clarification Justin!

KazushiR commented 1 year ago

Have to read the write-up as I didn't notice this.

github-actions[bot] commented 1 year ago

@KazushiR

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

Progress: "What is the current status of your project? What have you completed and what is left to do?"
Blockers: "Difficulties or errors encountered."
Availability: "How much time will you have this week to work on this issue?"
ETA: "When do you expect this issue to be completed?"
Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

_{You are receiving this comment because your last comment was before Tuesday, May 9, 2023 at 12:15 AM PST.}

ExperimentsInHonesty commented 1 year ago

@KazushiR We have not had an update from you, if we don't hear from you in the next 7 days, we will remove you from the issue. If you are not available to work on the issue, please unassign yourself from the issue, add a comment and then move it to the questions and review column

KazushiR commented 1 year ago

@KazushiR We have not had an update from you, if we don't hear from you in the next 7 days, we will remove you from the issue. If you are not available to work on the issue, please unassign yourself from the issue, add a comment and then move it to the questions and review column

Apologies as I have been a bit busy. I will not have time with this issue and will I assign myself for now.

ExperimentsInHonesty commented 1 year ago

@hackforla/website-merge Please review, cleanup and add back to the prioritized backlog

github-actions[bot] commented 1 year ago

Hi @romainyvernes, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] commented 1 year ago

Hi @KyleA99, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

KyleA99 commented 1 year ago

Availability: Mon - Sun 5-8 pm ETA: Sunday 11/5

KyleA99 commented 1 year ago

Wasnt able to start this yet. Pushing ETA back a week.

Availability: Mon - Sun 5-8 pm ETA: Sunday 11/12

KyleA99 commented 1 year ago

Issue is still in progress.

Availability: Mon - Sun 5-8 pm ETA: Thursday 11/16

KyleA99 commented 1 year ago

Still in progress.

Availability: Mon - Sun 5-8 pm ETA: Thursday 12/1

github-actions[bot] commented 1 year ago

@KyleA99

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

Progress: "What is the current status of your project? What have you completed and what is left to do?"
Blockers: "Difficulties or errors encountered."
Availability: "How much time will you have this week to work on this issue?"
ETA: "When do you expect this issue to be completed?"
Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

_{You are receiving this comment because your last comment was before Monday, November 27, 2023 at 11:06 PM PST.}

KyleA99 commented 1 year ago

Unfortunately had to unassign myself from this task, slammed in real life and can't get to this in a timely manner.

github-actions[bot] commented 12 months ago

Hi @freaky4wrld, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

freaky4wrld commented 12 months ago

Availability: Evenings ETA: Thursday 12/14

freaky4wrld commented 11 months ago

Issue is still in progress. might take sometime due to slow pace work. Availability: Evenings ETA: EOD Thursday 12/18

freaky4wrld commented 11 months ago

@jdingeman I'm just confused can you tell me about, to which version of code I've to write the recommendations, the spreadsheet consist of a Permalink that doesn't match with the current version of code in gh-pages. So can you please clear on that. Thanks for the help

t-will-gillis commented 11 months ago

Hey @freaky4wrld FYI I don't believe Justin has been logging in recently so you might not get a response.

If I understand your question: I would ignore the Permalink and review using the current code on gh-pages.

freaky4wrld commented 11 months ago

Waiting for @roslynwythe suggestions for the issue that are going to be addressed on the onboarding meeting at 8th this month

roslynwythe commented 10 months ago

@freaky4wrld I moved this issue into "New Issue Approval" because I realized that the spreadsheet is out of date (for instance, it does not include toolkit and guides pages) and I need to consult with PM about how to proceed.

hackforla / website