img Tag Refactor: Citizen Engagement page

JessicaLucindaCheng commented 1 year ago

Prerequisite

Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash () to an img tag without an ending slash () so that the codebase is consistent with how we use img HTML tags.

Action Items

[x] In your local IDE, navigate to _includes/program-area-pages-cards.html

[x] Change the following from

<img class="sdg-image" src="{{ item.sdg-image-src }}" alt="{{ item.sdg-image-alt }}" />

to

<img class="sdg-image" src="{{ item.sdg-image-src }}" alt="{{ item.sdg-image-alt }}">

[x] Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)

Resources/Instructions

For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/_includes/program-area-pages-cards.html
Webpage: https://www.hackforla.org/citizen-engagement
This issue is tracked in HfLA-Website: img Tag Audit spreadsheet's img with Ending Slash tab, which is part of #4362

github-actions[bot] commented 1 year ago

Hi @oliviazhai, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

oliviazhai commented 1 year ago

ETA: Apr 13 end of the day Availability: Apr 12 8:00 Pm - 10:00 Pm

roslynwythe commented 1 year ago

Hi @oliviazhai please leave a comment outlining your progress and including your availability and ETA. If you no longer plan to work on this issue, please let us know. Thank you.

oliviazhai commented 1 year ago

@roslynwythe ETA: May 10 end of the day Availability: May 10 8:00 Pm - 10:00 Pm

ExperimentsInHonesty commented 1 year ago

@kiwookim, I don't understand why you moved this from the in progress column to prioritized backlog. You are not assigned to the issue and the person working on it gave an update within the last 5 days. Please either add an explanation or if this was a mistake., please talk to some of the merge team to get help understanding what issues you can move on the board.

kiwookim commented 1 year ago

Hi Bonnie. It's Ki Woo. As I navigated through the HLA repo to familiarize myself with good first issues ', I misclicked. I didn't mean to close the issue. Although, now I realize I could have left a comment directly saying it was a mistake. I am so sorry for the confusion—my mistake.

Thanks for reaching out.

On Sat, May 13, 2023 at 10:02 PM Bonnie Wolfe @.***> wrote:

@kiwookim https://github.com/kiwookim, I don't understand why you moved this from the in progress column to prioritized backlog. You are not assigned to the issue and the person working on it gave an update within the last 5 days. Please either add an explanation or if this was a mistake., please talk to some of the merge team to get help understanding what issues you can move on the board.

— Reply to this email directly, view it on GitHub https://github.com/hackforla/website/issues/4449#issuecomment-1546808261, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWYUFOOWZ3ICT6OV4TNMJ3DXGBRMVANCNFSM6AAAAAAWYFXSIM . You are receiving this because you were mentioned.Message ID: @.***>

github-actions[bot] commented 1 year ago

@oliviazhai

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

Progress: "What is the current status of your project? What have you completed and what is left to do?"
Blockers: "Difficulties or errors encountered."
Availability: "How much time will you have this week to work on this issue?"
ETA: "When do you expect this issue to be completed?"
Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

_{You are receiving this comment because your last comment was before Tuesday, May 16, 2023 at 12:16 AM PST.}

hackforla / website