hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
317 stars 753 forks source link

Verify dependabot version updates to GHAs for issue-trigger.yml #4822

Closed t-will-gillis closed 1 year ago

t-will-gillis commented 1 year ago

Prerequisites

  1. You must be a member of Hack for LA to work on an issue. If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

    Overview

    Our repo's dependabot has been identifying the packages/dependencies for which a more recent version is available, and for each it has created a PR detailing which files in our codebase use that package/dependency. We need to check each of these files individually to determine whether we should or should not switch to the latest version.

    Action Items

    Refer to the issue-trigger.yml file and review with the version updates recommended by the dependabot. Select:

    • [x] PASSES TEST #4734 `uses: actions/github-script@v4` with `uses: actions/github-script@v6`
    • [x] PASSES TEST #4735 `uses: actions/checkout@v2` with `uses: actions/checkout@v3`
    • [x] PASSES TEST #4737 `uses: actions/checkout@v2` with `uses: actions/checkout@v3` Or:
    • [ ] ~FAILS: #4734. Do not update.~ UPDATE 7/17/23: With additional refactoring, this passes uses: actions/github-script@v6. See #4933
    • [ ] FAILS: #4735. Do not update.
    • [ ] FAILS: #4737. Do not update.

Merge team:

t-will-gillis commented 1 year ago

Issue #4189 might be updating the versions per 4734, 4735, 4737: If so this issue will be unnecessary. If not then issue should proceed.

github-actions[bot] commented 1 year ago

Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

t-will-gillis commented 1 year ago

Issue #4189 will be closed, with this issue taking over.