img Tag Refactor: _includes/about-page/about-card-sustainability.html - sdg-la.svg

[roslynwythe]

Prerequisite

1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash () to an img tag without an ending slash () so that the codebase is consistent with how we use img HTML tags.

Action Items

• [ ] In your local IDE, navigate to _includes/about-page/about-card-sustainability.html
• [ ] Remove the ending slash in the img HTML tag by changing

  <img src="/assets/images/sdg/sdg-la.svg" alt="" />

  to

  <img src="/assets/images/sdg/sdg-la.svg" alt="">

• [ ] The file may contain more than one instance of an img tag with a closing slash. Only change the single instance specified above. Do not leave any blank spaces before the closing bracket.
• [ ] Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 1 in the Resources/Instructions section below)

Resources/Instructions

1. Webpage(s): https://www.hackforla.org/about
2. This issue is tracked in HfLA-Website: img Tag Audit spreadsheet's img with Ending Slash tab, which is part of #4362

[github-actions[bot]]

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing: Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

• Wiki: How to create issues
• Wiki: How to read and interpret labels

[ExperimentsInHonesty]

@roslynwythe I am not sure how the inclusion of this

For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/assets/js/current-projects.js

helps me QA the change

[roslynwythe]

@ExperimentsInHonesty that was part of the template before I was assigned to the epic so I'm not sure I know exactly the reasoning behind it but I believe the idea is that you could browse to that file, search for the image filename specified in the issue title, and view the updated code. Please advise re: a better means of supporting QA.

[github-actions[bot]]

Hi @aidanwsimmons, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

[aidanwsimmons]

i. Availability: Available Monday-Wednesday before 6pm ii. ETA: Should be completed today

[aidanwsimmons]

Fixes #5171

What changes did you make?

• Removed '/' from end of img tag

Why did you make the changes (we will use this info to test)?

• refactored so that the codebase is consistent with how we use img HTML tags

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

[aidanwsimmons]

removed self- didnt see my previous issue required changes