img Tag Refactor: _includes/about-page/about-card-sustainability.html - sdg2.svg

roslynwythe commented 1 year ago

Prerequisite

Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash () to an img tag without an ending slash () so that the codebase is consistent with how we use img HTML tags.

Action Items

[ ] In your local IDE, navigate to _includes/about-page/about-card-sustainability.html

[ ] Remove the ending slash in the img HTML tag by changing

<img src="/assets/images/sdg/sdg2.svg" alt="2 Zero Hunger" />

to

<img src="/assets/images/sdg/sdg2.svg" alt="2 Zero Hunger">

[ ] The file may contain more than one instance of an img tag with a closing slash. Only change the single instance specified above. Do not leave any blank spaces before the closing bracket.
[ ] Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 1 in the Resources/Instructions section below)

Resources/Instructions

Webpage(s): https://www.hackforla.org/about
This issue is tracked in HfLA-Website: img Tag Audit spreadsheet's img with Ending Slash tab, which is part of #4362

github-actions[bot] commented 1 year ago

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing: Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

nitin-pandita commented 1 year ago

@roslynwythe i am up for this

roslynwythe commented 1 year ago

Hi @nitin-pandita you must be a member of Hack for LA to work on our issues. Please see https://www.hackforla.org/join. You don't have to live in L.A to become a member!

nitin-pandita commented 1 year ago

@roslynwythe thank you for your reply 😄, do I have to sign up for contributing in any repo

ExperimentsInHonesty commented 1 year ago

@roslynwythe I am not sure how the inclusion of this

For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/assets/js/current-projects.js

helps me QA the change

roslynwythe commented 1 year ago

@ExperimentsInHonesty that was part of the template before I was assigned to the epic so I'm not sure I know exactly the reasoning behind it but I believe the idea is that you could browse to that file, search for the image filename specified in the issue title, and view the updated code. Please advise re: a better means of supporting QA.

ExperimentsInHonesty commented 11 months ago

@roslynwythe wouldn't I just check the about page and that specific image?

@ExperimentsInHonesty that was part of the template before I was assigned to the epic so I'm not sure I know exactly the reasoning behind it but I believe the idea is that you could browse to that file, search for the image filename specified in the issue title, and view the updated code. Please advise re: a better means of supporting QA.

github-actions[bot] commented 7 months ago

Hi @aidanwsimmons, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

aidanwsimmons commented 7 months ago

i. Availability: today untill 6pm, tuesday aftenoon-evening ii. ETA: EOD today

github-actions[bot] commented 7 months ago

@aidanwsimmons

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

Progress: "What is the current status of your project? What have you completed and what is left to do?"
Blockers: "Difficulties or errors encountered."
Availability: "How much time will you have this week to work on this issue?"
ETA: "When do you expect this issue to be completed?"
Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

_{You are receiving this comment because your last comment was before Monday, February 19, 2024 at 11:06 PM PST.}

aidanwsimmons commented 7 months ago

Progress: issue seems to be resolved- ive verified my gh-pages branch is up to date, but im not seeing a back slack at the end of the tag as specified by the action item. Blockers: see above unasigning myself from issue

JessicaLucindaCheng commented 6 months ago

As Aidan mentioned above, this problem seems to be already fixed:

https://github.com/hackforla/website/blob/ca51380f1993223af84d71420052b2983b457579/_includes/about-page/about-card-sustainability.html#L49

hackforla / website