ER: Update Twitter Logo

hackforla / website

Hack for LA's website

https://www.hackforla.org

GNU General Public License v2.0

295 stars 725 forks source link

ER: Update Twitter Logo #5747

Open Kaushik080 opened 9 months ago

Kaushik080 commented 9 months ago

Dependency

https://github.com/hackforla/website/issues/6654

Emergent Requirement - Problem

The Twitter logo is outdated and needs to be updated to the new X logo.

To reproduce - Go to the footer of the website In the current version of the website the logo of the twitter is not updated.

Issue you discovered this emergent requirement in

none by observation

Date discovered

2023-10-21

Did you have to do something temporarily

[ ] YES
[x] NO

Who was involved

@Kaushik080

What happens if this is not addressed

The website looks less up-to-date

Resources

Recommended Action Items

[x] Make a new issue
[ ] Discuss with team
[ ] Let a Team Lead know

Potential solutions [draft]

Kaushik080 commented 9 months ago

I would like to work on this

adrianang commented 9 months ago

Hi @Kaushik080! In order to contribute to the codebase and work on (or create) issues, you must be a part of the Hack for LA organization. You can join Hack for LA by attending an upcoming onboarding session; below are instructions on how to join. Thank you for your interest, and we hope to see you soon!

Prerequisite

Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.

adrianang commented 9 months ago

Closing issue; developer is not a member of Hack for LA.

ExperimentsInHonesty commented 9 months ago

This issue needs to be rewritten as an ER.

JessicaLucindaCheng commented 4 months ago

@ExperimentsInHonesty Should we specify which logo to use?

https://about.x.com/en/who-we-are/brand-toolkit

ExperimentsInHonesty commented 4 months ago

@JessicaLucindaCheng use the black log with and white background png and we should be modifying on the fly based on where its used. See the issues we have already written for doing the same thing for the Slack logo. I may be wrong about which one to use, see slack issue.

github-actions[bot] commented 4 months ago

Hi @JessicaLucindaCheng, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

ExperimentsInHonesty commented 3 months ago

I found the ER where we addressed the changing the slack icon to just one image file (an SVG) and then using CSS to change it based on where we want it to appear: https://github.com/hackforla/website/issues/5758#issuecomment-1789866630. I don't know what else needs to be done. But that issue doesn't seem to be finished, so I have reopened it and will add both of these issues to the agenda https://github.com/hackforla/website/issues/5758#issuecomment-2041682576

ExperimentsInHonesty commented 3 months ago

As soon as the dependency is cleared that will provide instructions for how to do this, and this ER and its resulting issues can get updated/written.