Removing instances of "test" as a substring in the events page

freaky4wrld commented 8 months ago

Dependency

[x] #6023, because the editing is going to be done on the events page.

Overview

As developers we want to remove the instances of "test" from the events page. We need to add logic for removing any event that contain "test"(case-insensitive) from the events page

Action Items

[x] Go to the file /assets/js/utility/vrms-events.js
[x] Find the code-block rendering events from the VRMS to the website
[x] Add logic to remove any instances of events with "test" as a substring from the name field of the event. (We want to filter out the vague events created by VRMS for testing from our /events page).
[x] Make sure the desired results are shown by testing the changes with docker

Merge Team

[x] Release the dependency on #6059 then move that issue into New Issue Approval

Resources/Instructions

https://github.com/hackforla/website/blob/gh-pages/assets/js/utility/api-events.js
https://www.hackforla.org/events/
This issue is created from the ER https://github.com/hackforla/website/issues/6289

github-actions[bot] commented 8 months ago

Hi @freaky4wrld.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:

Complexity, Role, Feature, Size

NOTE: Please ignore this comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

roslynwythe commented 8 months ago

Thank you @freaky4wrld for writing this issue. Just a few notes:

after writing an issue, please apply the label "ready for dev lead" so that I can review it
the issue looks good, but I'm not sure what the instructions/procedure for testing it should be, so I suggest that we ask Bonnie about that.

freaky4wrld commented 8 months ago

the issue looks good, but I'm not sure what the instructions/procedure for testing it should be, so I suggest that we ask Bonnie about that.

Should I mention this issue in the agenda?

ExperimentsInHonesty commented 8 months ago

@freaky4wrld yes, that is the place to put it, but also, you could have added a ready for product label, once you were ready for me to review it.

I think this solution is elegant. However, we may want to filter it out in the code that builds the pages. Meaning later if we want to create a page that shows all the garbage they are sending us (e.g, projects that should not have event data, projects that don't match our projects.md files, we will have to refactor that js file, and the files that use it).

github-actions[bot] commented 8 months ago

Hi @freaky4wrld, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

roslynwythe commented 7 months ago

I believe we would modify assets/js/right-col-content.js

roslynwythe commented 7 months ago

Hi @freaky4wrld

I believe that the relevant code will be located in assets/js/right-col-content.js but just to be sure, we might want to make the first Action Item something like this:
```
- [ ] Go to the file `assets/js/right-col-content.js` (**Note to dev lead: prior to prioritization, confirm that the relevant code is still located in this file**)
```
In the 3rd Action Item you might want to specify that we only want to filter out events in which the substring test is found within the name field, so that we don't filter out events that have the test substring in the description or other field

elliot-d-kim commented 6 months ago

I think a parallel problem exists on the Project Meetings page. Under Wednesday, the last item is "10:00 pm - 11:00 pm Testing Test-EventName, Testing." I didn't find an ER or issue specific to the Project Meetings page, should these be rolled into one issue or should I create a new ER/issue that mirrors this one? Maybe the test data could be filtered out more upstream, closer to when the data is fetched initially from VRMS?

Additionally, all the 'Admin team' links on Project Meetings are https://www.hackforla.org/undefined.

freaky4wrld commented 6 months ago

@elliot-d-kim thanks for mentioning the points, this is the link to the ER https://github.com/hackforla/website/issues/6289

@roslynwythe, @bonniewolfe can you please suggest on what to do with the Admin Team links on the Project Meetings page

ExperimentsInHonesty commented 6 months ago

@freaky4wrld please don't forget to add the ready for product label if you need my attention on an issue. I just came across this by chance, because I am looking at all the ready for dev lead issues to see if some of them can be ready for merge team.

can you please suggest on what to do with the Admin Team links on the Project Meetings page

Yes, please point it at https://www.hackforla.org/join. It's not the best long term solution, but we don't have a page that describes how to join the admin team yet.

I made an ER for that #6833.

ExperimentsInHonesty commented 6 months ago

p.s. I added the draft label since this issue is still being drafted. Remove that when you are ready and put one of these labels depending on what you want to happen next

ready for dev lead if you want RW to review,
ready for prioritization if you both think it's done and ready for me to put it in the prioritized backlog
ready for product if you want me to answer any more questions.

p.p.s I added the ready for merge team label since I am handing this issue back to you with the answer you need, so obviously remove that, when you put one of the above labels on.

roslynwythe commented 6 months ago

@freaky4wrld Please note that #6023 is completed with #6815. Due to the refactoring in the PR, it may be necessary to change the instructions in this issue. See the note in the first Action Item. Also for the last two Action Items instead of "events-display page" you might want to specify /events. Please let me know when you feel the issue is ready.

freaky4wrld commented 6 months ago

@roslynwythe I guess I've checked the location for the file and made changes on my local environment to get the desired results. In my opinion the issue is ready now.

roslynwythe commented 4 months ago

@freaky4wrld I believe that due to the refactoring in #6815, the logic for retrieving VRMS events for display on the events and project pages is now contained in /assets/js/utility/vrms-events.js so please update the first Action Item.

HackforLABot commented 1 month ago

Hi @dcotelessa, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

dcotelessa commented 1 month ago

Availability: M-F: 4pm-6pm PST ETA: 2 hors

hackforla / website