hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
324 stars 760 forks source link

ER: Inconsistent filtering behavior for "Languages/Technologies/Tools" category #6709

Open jphamtv opened 5 months ago

jphamtv commented 5 months ago

Emergent Requirement - Problem

  1. The filter behavior for the 'Languages/Technologies/Tools' category on the Home and Projects pages is confusing and inconsistent. For example, when selecting 1 language and 1 technology, the filter uses OR logic, but when selecting 2 items from the same category, the filter uses AND logic.

  2. There are duplicate Languages and Tools categories on the Home page.

    Homepage filter:

    Screenshot 2024-04-23 at 12 21 51

Issue you discovered this emergent requirement in

Date discovered

4/22/24

Did you have to do something temporarily

Who was involved

@jphamtv

What happens if this is not addressed

Users may select filters that don't match their intended search, leading to incorrect results.

Resources

www.hackforla.org www.hackforla.org/projects current-projects.js

Recommended Action Items

Potential solutions [draft]

After discussing with the Dev Lead team, the solution is to create the following 2 issues:

github-actions[bot] commented 5 months ago

Hi @jphamtv.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:

NOTE: Please ignore this comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

github-actions[bot] commented 5 months ago

Hi @jphamtv, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

ExperimentsInHonesty commented 5 months ago

@jphamtv A couple of things have come up since we talked yesterday.

  1. There is already an ER for the search tips and its both comprehensive and less comprehensive at the same time. https://github.com/hackforla/website/issues/6327
  2. After reviewing the other issue, I think the solution could be better than having the text visible. So here is what I suggest. I suggest that you post a comment on the other issue with the screenshots and the following changes and then remove issue 3 from this ER.

Proposed solution

Add link below the Filter section that opens a modal that has the following text and table

Link Text

Search Tips

Modal Content

To find projects matching any of your interests, use Boolean Operators in the Search Bar. See the table below to understand more how Boolean Operators work.

Boolean Operators Meaning Example
AND Limit results React AND Node (Search for project cards that contain both React and Node.)
OR One term OR another Python OR Javascript (Search for project cards that contains Python OR JavaScript.)
- Exclude a term from the search React -Django (Limits project card results to only those with React and not the term Django.)

Link Text placement on Desktop/Tablet:

Screenshot 2024-04-23 at 12 20 23

Link Text placement on Mobile:

Screenshot 2024-04-23 at 13 14 43
jphamtv commented 5 months ago

@ExperimentsInHonesty - Removed Issue 3 from this ER, and posted a comment on #6327 with the screenshots and changes as suggested in the previous comment.

github-actions[bot] commented 4 months ago

Hi @marioantonini, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

marioantonini commented 4 months ago
  1. Availability: M-W 2-5pm
  2. ETA: EoD 05/21/2024
marioantonini commented 4 months ago

Update:

  1. Availability: W-Th, Sat-Sun 2-5pm
  2. ETA: EoD 05/26/2024
github-actions[bot] commented 4 months ago

@marioantonini

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, May 28, 2024 at 12:06 AM PST.

github-actions[bot] commented 4 months ago

@marioantonini

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, June 4, 2024 at 12:06 AM PST.

marioantonini commented 4 months ago
  1. Availability: Sat-Sun 2-5pm
  2. ETA: EoD 06/09/2024
github-actions[bot] commented 3 months ago

@marioantonini

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, June 18, 2024 at 12:06 AM PST.

github-actions[bot] commented 3 months ago

@marioantonini

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Wednesday, June 19, 2024 at 1:48 PM PST.

marioantonini commented 3 months ago
  1. Availability: Sun 2-6 pm, Tue, Wed 1-4pm
  2. ETA: EoD 06/25/2024
k-cardon commented 2 weeks ago

Hi @ExperimentsInHonesty, Roslyn suggested I might be able to work on this issue (or alternatively #6145) in order to make a medium issue for myself to work on (and a large issue for the backlog). Is that acceptable?

HackforLABot commented 2 weeks ago

Hi @k-cardon, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

k-cardon commented 1 week ago

Availability: usually Thursday evening and weekends ETA: not sure if I'm permitted to work on this yet-- @roslynwythe asked me to check with @ExperimentsInHonesty before starting.

k-cardon commented 1 week ago

I'm going to remove myself from this since I'm not sure if I'm permitted to work on it, and there are medium issues available now.