hackforla / website

Hack for LA's website

https://www.hackforla.org

GNU General Public License v2.0

292 stars 707 forks source link

Added GitHub handle option for Eva Kwock in design-systems.md #6768

Closed taylorbeee closed 1 month ago

taylorbeee commented 1 month ago

Fixes #6706

What changes did you make?

Added empty github-handle variable under Eva Kwock's name variable.

Why did you make the changes (we will use this info to test)?

Eventually the added github-handle will replace the github and picture variables, reducing redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Added an empty variable. No visual changes to the website.

github-actions[bot] commented 1 month ago

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b taylorbeee-add-github-handle-Eva-Kwock-6706 gh-pages
git pull https://github.com/taylorbeee/website.git add-github-handle-Eva-Kwock-6706

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/taylorbeee/website/blob/add-github-handle-Eva-Kwock-6706/CONTRIBUTING.md

t-will-gillis commented 1 month ago

Hey @jenjenkayi, @patelbansi3009, @taylorbeee, @nssensalo, @ShamaaTabassum as a reminder, while you are waiting for your PRs to be reviewed, please consider reviewing each other’s good first issue PRs and any other PRs you feel comfortable with. Instructions are here for How to Review Pull Requests . You should aim to review two PRs for every PR you submit, and each PR ideally should have two or more reviewers. Thanks!

6746, #6767, #6768, #6770, #6772

taylorbeee commented 1 month ago

@ajb176 I fixed the typo in the PR. Good eye, and thanks for pointing that out!

del9ra commented 1 month ago

Review ETA: EST 11 PM 5/1/24 Availability: 5-8 PM Thursday