hackforla / website

Hack for LA's website

https://www.hackforla.org

GNU General Public License v2.0

286 stars 700 forks source link

Add surveys/ in cspell.json 5847 #6772

Closed ShamaaTabassum closed 2 weeks ago

ShamaaTabassum commented 3 weeks ago

Fixes #5847

What changes did you make?

-Added "surveys/ " to "ignorePaths" array in cspell.json

Why did you make the changes (we will use this info to test)?

So that "surveys/ " file should be excluded from spell checking,

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

github-actions[bot] commented 3 weeks ago

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ShamaaTabassum-add-surveys/-in-cspell.json-5847 gh-pages
git pull https://github.com/ShamaaTabassum/website.git add-surveys/-in-cspell.json-5847

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/ShamaaTabassum/website/blob/add-surveys/-in-cspell.json-5847/CONTRIBUTING.md

t-will-gillis commented 2 weeks ago

Hey @jenjenkayi, @patelbansi3009, @taylorbeee, @nssensalo, @ShamaaTabassum as a reminder, while you are waiting for your PRs to be reviewed, please consider reviewing each other’s good first issue PRs and any other PRs you feel comfortable with. Instructions are here for How to Review Pull Requests . You should aim to review two PRs for every PR you submit, and each PR ideally should have two or more reviewers. Thanks!

6746, #6767, #6768, #6770, #6772

patelbansi3009 commented 2 weeks ago

Availability: Mon-Thu (11PM - 6PM) EST ETA: EOD 04/29

patelbansi3009 commented 2 weeks ago

Great work @ShamaaTabassum!

Used the correct branch.
Accurately linked the issue.
Code changes are made as requested in the issue.
There are no visual changes on the website.

Keep up the good work!

t-will-gillis commented 2 weeks ago

Hey @ShamaaTabassum Looks great, congrats on completing your first pull request!

As a friendly note for the next time: on the description above, if you add a space between the dash and the text following, the Markdown will render correctly. For example:

-My text is here

My text is here

Great work!