Closed partapparam closed 1 week ago
Want to review this pull request? Take a look at this documentation for a step by step guide!
From your project repository, check out a new branch and test the changes.
git checkout -b partapparam-auto-response-feature-branch-issues-1940 gh-pages
git pull https://github.com/partapparam/website.git auto-response-feature-branch-issues-1940
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
https://github.com/partapparam/website/blob/auto-response-feature-branch-issues-1940/CONTRIBUTING.md
@t-will-gillis attached are photos of my test. I added test comments in the issue to ensure no other comments are marked outdated
.
Comment marked as outdated.
The issue with multiple comments marked as outdated that were added for Feature: Feature Branch
label.
This image shows that the workflow is triggered, but the job is skipped.
Hey @partapparam Thank you for your revisions and thanks for researching the reason for the multiple false starts on the workflow.
I will try to look at this again in the next day or so.
Hey @partapparam so first thing- this looks great and it looks like this PR does everything the initiating issue asked it to do. Well done!
About the workflow calls, I understand what you are saying and I was playing with your code a little bit to see what it would do. You already know this, but I don't see a way to get around this workflow being called every time an individual label is added or removed. On one hand it doesn't feel change things but on the other it is annoying to have 9-10 job runs just to open an issue and add labels.
I apologize in advance, but I would like to discuss this effect with Bonnie and the team and ask if this is really what we want to happen and if this particular functionality truly is needed.
Again, emphasize great work on your part
@t-will-gillis thank you so much for all the work and time you're putting into this PR!!
I've made the requested changes:
permissions
github.event_name == 'issues'
Hide
return
statement from both Jobs. Regarding the message this comment has been minimized
. This seems to be a bug in the Github GraphQL API. See this attached discussion. minimizeComment
The minimizeComment
is only available through the GraphQL API, not REST, and seems to be the only route to achieve the desired outcome.
Testing the response from the GraphQL API, I was able to replicate the error mentioned in the link above. I pass in the OUTDATED
flag as minimizeReason
, but it returns as outdated
from the API. I believe this is causing the generic message.
Fixes #1940
What changes did you make?
issue-trigger.yml
to include tracking oflabeled
andunlabeled
eventsfeature: feature branch
label is added during issue creation, or after issue creation, the comment is addedfeature: feature branch
label is removed, the comment is hiddengithub-actions/trigger-issue
add-comments
script that will trigger onlabeled
event and add a comment to the issueoutdate-comments
script that will trigger onunlabeled
event and hide the comment as 'OUTDATED'hide-issue-comment.js
ingithub-actions/utils
folderWhy did you make the changes (we will use this info to test)?
To post a comment on any issue that gets a label
feature: feature branch
with details about what the developer should do. This was done in accordance with the below requirements.feature: feature branch
label is added during issue creation, the comment is addedfeature: feature branch
label is applied after issue creation, the comment is addedfeature: feature branch
label is removed, the comment is hiddenNo visible changes to site