hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
286 stars 699 forks source link

Auto response to feature branch issues - #1940 #6773

Closed partapparam closed 1 week ago

partapparam commented 2 weeks ago

Fixes #1940

What changes did you make?

Why did you make the changes (we will use this info to test)?

To post a comment on any issue that gets a label feature: feature branch with details about what the developer should do. This was done in accordance with the below requirements.

No visible changes to site

github-actions[bot] commented 2 weeks ago

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b partapparam-auto-response-feature-branch-issues-1940 gh-pages
git pull https://github.com/partapparam/website.git auto-response-feature-branch-issues-1940

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/partapparam/website/blob/auto-response-feature-branch-issues-1940/CONTRIBUTING.md  
partapparam commented 2 weeks ago

@t-will-gillis attached are photos of my test. I added test comments in the issue to ensure no other comments are marked outdated.

Comment marked as outdated.

Screenshot 2024-04-29 at 8 16 15 PM

The issue with multiple comments marked as outdated that were added for Feature: Feature Branch label.

Screenshot 2024-04-29 at 8 15 25 PM

This image shows that the workflow is triggered, but the job is skipped.

Screenshot 2024-04-29 at 8 11 07 PM
t-will-gillis commented 2 weeks ago

Hey @partapparam Thank you for your revisions and thanks for researching the reason for the multiple false starts on the workflow.

I will try to look at this again in the next day or so.

t-will-gillis commented 2 weeks ago

Hey @partapparam so first thing- this looks great and it looks like this PR does everything the initiating issue asked it to do. Well done!

About the workflow calls, I understand what you are saying and I was playing with your code a little bit to see what it would do. You already know this, but I don't see a way to get around this workflow being called every time an individual label is added or removed. On one hand it doesn't feel change things but on the other it is annoying to have 9-10 job runs just to open an issue and add labels.

I apologize in advance, but I would like to discuss this effect with Bonnie and the team and ask if this is really what we want to happen and if this particular functionality truly is needed.

Again, emphasize great work on your part

partapparam commented 1 week ago

@t-will-gillis thank you so much for all the work and time you're putting into this PR!!

I've made the requested changes:

Regarding the message this comment has been minimized. This seems to be a bug in the Github GraphQL API. See this attached discussion. minimizeComment

The minimizeComment is only available through the GraphQL API, not REST, and seems to be the only route to achieve the desired outcome.

Testing the response from the GraphQL API, I was able to replicate the error mentioned in the link above. I pass in the OUTDATED flag as minimizeReason, but it returns as outdated from the API. I believe this is causing the generic message.

Screenshot 2024-05-07 at 2 38 14 PM