hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
286 stars 700 forks source link

Manage truncation of contributors name in filter tag on toolkit page #6787

Open roslynwythe opened 2 weeks ago

roslynwythe commented 2 weeks ago

Overview

As developers we need to provide a visual cue when a contributor's name is truncated within a filter tag on the Toolkit page. This occurs at medium-to-large screen sizes for some contributor names.

Action Items

Resources/Instructions

Screenshot - truncation of name "Ahdithan Uthayakumar Tarang Gupta" ![image](https://github.com/hackforla/website/assets/5314153/e56b7fbf-eff4-4e8d-a408-bac9c7457911)

Toolkit webpage | HTML | include | JavaScript

github-actions[bot] commented 2 weeks ago

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:

NOTE: Please ignore this comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

roslynwythe commented 2 weeks ago

@ExperimentsInHonesty Is this the strategy you had in mind? And should we check all filter tags for truncation, or just the filter tags representing contributor names?

ExperimentsInHonesty commented 2 weeks ago

@roslynwythe All other columns should have a limit to the characters, and only people's names should be as long as they need with visible truncation (...)

github-actions[bot] commented 2 weeks ago

Hi @roslynwythe, we notice that you are assigned to an issue that you authored. Please remember to add the Draft label to this issue while you are working on it.

roslynwythe commented 2 weeks ago

@roslynwythe All other columns should have a limit to the characters, and only people's names should be as long as they need with visible truncation (...)

  • full name will appear on the card itself

I don't see the name of the contributor on the card. Should I make an ER for that? Will we need a designer ?

  • if you ctrl-F or cmd-F and search for the full name it must highlight the name on the filters (is that even possible)?

Yes when I do ctrl-F it does highlight the name on the filters.

This issue is ready for prioritization, unless you feel it needs more guidance re: implementation?

ExperimentsInHonesty commented 1 week ago

@roslynwythe

I don't see the name of the contributor on the card. Should I make an ER for that? Will we need a designer ?

It's a future feature that will arrive with the cards when they are different (another design team is working on that)

Bonnie:

if you ctrl-F or cmd-F and search for the full name it must highlight the name on the filters (is that even possible)?

Roslyn:

Yes when I do ctrl-F it does highlight the name on the filters.

Bonnie: What I mean was if the name is truncated, how will it be responsive to someone searching the persons whole name using the traditional ctrl-f when what it shows on the screen is ...