Refactored JavaScript files so that Events page sources meeting data from vrms_data.json

irais-valenzuela commented 2 weeks ago

Fixes #6023

What changes did you make?

Created a new file in assets/js/utility called vrms-events.js to handle data fetching from the vrms_data.json file, vrms data sorting, and vrms data formatting for both project.html and right-col-content.html page.
The project.js file no longer has sorting and time formatting functions sortByDate and timeFormat as they were moved to vrms-events.js file and timeFormat was replaced with localeTimeIn12Format. Project.js still uses sortByDate and formatting functions but they're are now coming from vrms-events.js.
The right-col-content.js file now has the insertEventSchedule functionality that used to live in api-events.js. As well as other functions that used to be in api-events.js.
Api-events.js is no longer being used for right-col-content.js to grab event data so most of that file is commented out.
In summary, both project.html and right-col-content.html now share data fetching, sorting, and formatting functionality.

Why did you make the changes (we will use this info to test)?

Needed to reduce the latency and improve the reliability of the Events page and leverage the vrms_data.json file that already had event data to render meeting times for events page.
Both project.html and right-col-content.html had data fetching, sorting, and formatting logic that could be shared by both files.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

No changes to website.

Visuals after changes are applied

No changes to website.

github-actions[bot] commented 2 weeks ago

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b irais-valenzuela-refactor-js-events-page-6023 gh-pages
git pull https://github.com/irais-valenzuela/website.git refactor-js-events-page-6023

aadilahmed commented 1 week ago

Review ETA: EOD 5/7/24 Availability: 9-5 PM M-F

irais-valenzuela commented 1 week ago

@aadilahmed Thanks for catching that! I just restored the code. Let me know if everything else is good.

hackforla / website