search

hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
292 stars 707 forks source link

worked on adding githandle for Dr. Stephen M. Hubbard #6856

Closed deepak-getpu closed 1 week ago

deepak-getpu commented 2 weeks ago

Fixes #6856

What changes did you make?

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied ![image](Paste_Your_Image_Link_Here_After_Attaching_Files)
Visuals after changes are applied ![image](Paste_Your_Image_Link_Here_After_Attaching_Files)
github-actions[bot] commented 2 weeks ago

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b deepak-getpu-update-givelink-2009 gh-pages
git pull https://github.com/deepak-getpu/website.git update-givelink-2009
roslynwythe commented 2 weeks ago

@deepak-getpu Please link this PR to an issue by replacing "replace_this_text_with_the_issue_number" with the issue number, and complete the remaining fields. Thank you

LRenDO commented 2 weeks ago

Hi @deepak-getpu! Thanks for working on this issue! In addition to the changes @ajb176 requested, also make sure you add the same labels on this pull request as on the original issue. (This usually this happens automatically, but sometimes it doesn't work. It generally fails when the issue number isn't added at the time the PR was created.) Please also remove any unused bullet points from the original PR comment.

deepak-getpu commented 1 week ago

I was trying to do corrections by 1) re-adding in git, 2) commit 3)push in the new branch 4)running docker. However, I could not pull the request as indicated or demonstrated in the pre-boarding checklist documents. I am struggling to find a page similar to the one shown in the document for git pull. Any help and guidance on this would be appreciated.

t-will-gillis commented 1 week ago

Hi @deepak-getpu:

I was trying to do corrections by 10 re-adding in git, 2) commit 3)push in the new branch 4)running docker. However, I could not pull the request as indicated or demonstrated in the pre-boarding checklist documents. I am struggling to find a page similar to the one shown in the document for git pull. Any help and guidance on this would be appreciated.

It seems like there was a miscommunication. The changes that the reviewers were asking for did not involve Git or Docker.

Any of us will be happy to help you- I am happy to help you with this if we can set up a specific time. You can also bring your questions to one of the meetings. Let us know.

deepak-getpu commented 1 week ago

Hi Will,

Thank you for reaching out to me. I am desperately stuck completing my first issues as these steps involved here were completely new and i never had opportunity to learn these steps during my study of backend software development.

Help in completing my first issue would be really helpful. I am available almost all days this week from (9 am to 2.30 pm). For evening i would be available Monday, Wednesday, Thursday, and Friday from (6 pm to 9 pm Central time).

Thanking you, Deepak Acharya

On Tue, 21 May 2024 at 00:00, Will Gillis @.***> wrote:

Hi @deepak-getpu https://github.com/deepak-getpu:

I was trying to do corrections by 10 re-adding in git, 2) commit 3)push in the new branch 4)running docker. However, I could not pull the request as indicated or demonstrated in the pre-boarding checklist documents. I am struggling to find a page similar to the one shown in the document for git pull. Any help and guidance on this would be appreciated.

It seems like there was a miscommunication. The changes that the reviewers were asking for did not involve Git or Docker.

Any of us will be happy to help you- I am happy to help you with this if we can set up a specific time. You can also bring your questions to one of the meetings. Let us know.

— Reply to this email directly, view it on GitHub https://github.com/hackforla/website/pull/6856#issuecomment-2121743332, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEESUXZDPI4Y7AK2HT4VTZDZDLIG5AVCNFSM6AAAAABHXHMUTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRG42DGMZTGI . You are receiving this because you were mentioned.Message ID: @.***>

deepak-getpu commented 1 week ago

Closing this pull request, replaced by #6886.