search

hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
294 stars 723 forks source link

ER: Toolkit Link Fix #6919

Open ramitaarora opened 1 month ago

ramitaarora commented 1 month ago

Emergent Requirement - Problem

In the branch feature-homepage-launch, when trying to navigate to /toolkit/ or any of the associated navigation links, the link is replaced with /toolkit/?.

Issue you discovered this emergent requirement in

Date discovered

May 23, 2024

Did you have to do something temporarily

Who was involved

@ramitaarora @roslynwythe

What happens if this is not addressed

The link will redirect to the Toolkit Page, but none of the anchor links will work.

Resources

_data/navigation/toolkit.yml pages/toolkit.html _includes/current-guides.html assets/js/toolkit.js

Recommended Action Items

Potential solutions [draft]

Fix any redirections in toolkit.js file on the gh-pages branch.

github-actions[bot] commented 1 month ago

Hi @ramitaarora.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:

NOTE: Please ignore this comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

roslynwythe commented 1 month ago

Thank you @ramitaarora for writing this ER.

@ExperimentsInHonesty I think this ER is ready, but I have a question. The issue with redirection on the toolkit page was discovered in the feature-homepage-launch branch in the context of adding named anchors for the dropdown menu, but it also exists in the `gh-pages' branch. Which branch should we target in the new issue?

ExperimentsInHonesty commented 3 weeks ago

@roslynwythe we will fix it in the gh-pages branch and then when the homepage branch is updated next, it will get the update as well. Jessica has been doing the updates.