ER: Toolkit Link Fix

[ramitaarora]

Emergent Requirement - Problem

In the branch feature-homepage-launch, when trying to navigate to /toolkit/ or any of the associated navigation links, the link is replaced with /toolkit/?.

Issue you discovered this emergent requirement in

• 2455

Date discovered

May 23, 2024

Did you have to do something temporarily

• [ ] YES
• [x] NO

Who was involved

@ramitaarora @roslynwythe

What happens if this is not addressed

The link will redirect to the Toolkit Page, but none of the anchor links will work.

Resources

_data/navigation/toolkit.yml pages/toolkit.html _includes/current-guides.html assets/js/toolkit.js

Recommended Action Items

• [x] Make a new issue
• [ ] Discuss with team
• [ ] Let a Team Lead know

Potential solutions [draft]

Fix any redirections in toolkit.js file on the gh-pages branch.

[github-actions[bot]]

Hi @ramitaarora.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:

• Complexity, Role, Feature

NOTE: Please ignore this comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

• Wiki: How to create issues
• Wiki: How to read and interpret labels

[roslynwythe]

Thank you @ramitaarora for writing this ER.

@ExperimentsInHonesty I think this ER is ready, but I have a question. The issue with redirection on the toolkit page was discovered in the feature-homepage-launch branch in the context of adding named anchors for the dropdown menu, but it also exists in the `gh-pages' branch. Which branch should we target in the new issue?

[ExperimentsInHonesty]

@roslynwythe we will fix it in the gh-pages branch and then when the homepage branch is updated next, it will get the update as well. Jessica has been doing the updates.

[8alpreet]

Hi,

I've looked a bit into this issue and found that the '?' & anchor hashes are related but separate.

'?'

The '?' is added because line 261 in assets/js/toolkit.js appends a '?' to path even if there are no filters.

Anchor Hashes

Currently there is no logic to handle hashes within the function which contains line 261. The code does not take the hash portion of the URL into account and simply updated the location.

Path Forward:

For the '?' issue , I've drafted an issue #7636. For the anchor hashes, we would need to create a separate issue. I'm not sure if certain steps are involved in doing that or if I can simply create the issue.

[HackforLABot]

Hi @8alpreet, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

[8alpreet]

Availability

Weekdays 3-7 p.m. PT

ETA

Oct 29, 2024 by 9:00 p.m. PT

Status

1. Needs two issues:
   • Issue #7636 created (in progress)
   • Second issue pending creation

Next steps

• Finalize first issue
• Create and implement second issue

[8alpreet]

Updated ETA

Oct 30, 2024 by 9:00 p.m. PT

[8alpreet]

Hi merge team, I have created the following issues: #7636 & #7668