Closed roslynwythe closed 2 months ago
Hi @roslynwythe.
Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
NOTE: Please ignore this comment if you do not have 'write' access to this directory.
To add a label, take a look at Github's documentation here.
Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.
After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.
Additional Resources:
Hi @andyphancode, thank you for taking up this issue! Hfla appreciates you :)
Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)
You're awesome!
P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)
Availability: Throughout 6/15/24 - 6/18/24 ETA: EOD 6/17/24
Pull request created at https://github.com/danielridgebot/check-ghpages-versions/pulls
Overview
As developers we need to update the deprecated
set-output
command in the Daniel Ridge workflows and update the version of Node, in order to comply with GitHub recommendations and ensure the continuing operation of the workflows. There is also an issue with the secret that must be resolved.Details
The Daniel Ridge Bot repo check-ghpages-versions contains the scheduled workflows
check-gh-pages-version.yml
andcheck-ruby-version.yml
which automatically check the dependencies for the Docker image, and generate issues in the ops repository (github.com/hackforla/ops) if an update is required.The workflow had stopped running due to inactivity in the repository. #6266 was created to add a "keepalive" step to prevent the workflow from stopping in the future
However, even when the repository is active, the workflows do not behave as expected. See the Resources/Instructions section for a screenshot of a log depicting the current behavior. In addition, the following warnings are observed:
The
set-output
command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commandsNode.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Based on this comment https://github.com/danielridgebot/check-ghpages-versions/pull/21#issuecomment-2110968610, the secret name referenced in the workflows is incorrect and needs to be updated.
Action Items
.github/workflows/check-gh-pages-version.yml
and.github/workflows/check-ruby-version.yml
so that the result of the step 'Check for modified files is set using Environment files instead ofset-output
actions/checkout@v3
withactions/checkout@v4
.github/workflows/check-gh-pages-version.yml
and verify that the appropriate issues were createdResources/Instructions
GHA log showing failed run
![image](https://github.com/hackforla/website/assets/5314153/514f6dac-d09e-4a77-8e14-d7d7244ff9be)Check Github Pages Gem Version and Open New Issue on Change
Check Ruby Version and Open New Issue on Change
check-gh-pages-version.yml
check-ruby-version
GitHub blog post - GitHub Actions: Deprecating save-state and set-output commands
GitHub Actions: Transitioning from Node 16 to Node 20