Open ino-iosdev opened 2 months ago
Hi @ino-iosdev.
Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
NOTE: Please ignore this comment if you do not have 'write' access to this directory.
To add a label, take a look at Github's documentation here.
Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.
After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.
Additional Resources:
Hey @ino-iosdev good start on this! Here are some suggestions:
CONTRIBUTING.md
, Section 3.1.b.i. around or after line 889 (your 2nd screenshot). Where our docs say - Please change it to provide a summary of what you did.
you could recommend adding another bullet - Note: Please do not include the issue number in the PR title; a PR number will be added automatically.
or some such. For the labels: role: back end/devOps, complexity: depending on the change this might be a good first issue, and feature: this would be p-feature: onboarding/contributing.md
One final thing, if this is approved, you should volunteer to write the issue for it.
Emergent Requirement - Problem
This problem was brought up during the weekly Sunday meeting on 06/09/24. A common mistake was discovered in the pull request title among many newly on-boarded devs, the issue ticket number was often added at the end of the title which would stack with the PR number, I have come across this problem in the PR review process 5 times in a row, which raised my concern, screenshot of a recent discovery below:
This might be caused by confusing the PR ticket number attached at the end of the title example in the pull request instruction as the issue ticket number, see below:
Issue you discovered this emergent requirement in
6982
6984
Date discovered
Did you have to do something temporarily
Who was involved
@ino-iosdev @t-will-gillis
What happens if this is not addressed
Resources
CONTRIBUTING.md#part-3-pull-requests
Recommended Action Items
Potential solutions [draft]
Replace Update Care Link in Credits Page - #2131 with Update Care Link in Credits Page
Replace Update Care Link in Credits Page - #2131 with Update Care Link in Credits Page - #2131 (DO NOT include issue ticket number in the PR title!)